Using r154087, the code below never terminates with -O2 and -O3. yang@yang-working:~$ svngcc -O2 -o small2 small.c yang@yang-working:~$ ./small2 1 1 ... yang@yang-working:~$ ./small1 1 2 exit! yang@yang-working:~$ cat small.c #include <stdio.h> static int my_add(int si1, int si2) { return (si1 > (50-si2)) ? si1 : (si1 + si2); } static unsigned int my_shift(unsigned int left, int right) { return (right > 100) ? left : (left >> right); } static int func_4(unsigned int p_6) { for (p_6 = 1; p_6 < 3; p_6 = my_add(p_6, 1)) { printf ("%d\n", p_6); if (my_shift(p_6, p_6)) { return 0; } } return 0; } int main(void) { func_4(0); printf("exit!\n"); return 0; } yang@yang-working:~$ svngcc -v Using built-in specs. COLLECT_GCC=svngcc COLLECT_LTO_WRAPPER=/home/yang/compilers/libexec/gcc/i686-pc-linux-gnu/4.5.0/lto-wrapper Target: i686-pc-linux-gnu Configured with: ../configure --enable-lto --prefix=/home/yang/compilers --program-prefix=svn --enable-languages=c,c++ --with-libelf=/home/yang/compilers : (reconfigured) ../configure --enable-lto --prefix=/home/yang/compilers --program-prefix=svn --with-libelf=/home/yang/compilers --enable-languages=c,lto,c++ --no-create --no-recursion : (reconfigured) ../configure --enable-lto --prefix=/home/yang/compilers --program-prefix=svn --with-libelf=/home/yang/compilers --enable-languages=c,c++,lto --no-create --no-recursion : (reconfigured) ../configure --enable-lto --prefix=/home/yang/compilers --program-prefix=svn --with-libelf=/home/yang/compilers --enable-languages=c,c++,lto --no-create --no-recursion : (reconfigured) ../configure --enable-lto --prefix=/home/yang/compilers --program-prefix=svn --with-libelf=/home/yang/compilers --enable-languages=c,c++,lto --no-create --no-recursion Thread model: posix gcc version 4.5.0 20091110 (experimental) (GCC)
Confirmed.
Re-confirmed.
This is early IPA-SRA which transforms <bb 2>: goto <bb 9>; <bb 3>: p_6.0_3 = (int) p_6_1; if (p_6.0_3 <= 100) goto <bb 4>; else goto <bb 5>; <bb 4>: p_6_6 = p_6_1 >> p_6.0_3; <bb 5>: # p_6_7 = PHI <p_6_1(3), p_6_6(4)> if (p_6_7 != 0) goto <bb 10>; else goto <bb 6>; <bb 6>: if (p_6_1 <= 49) goto <bb 7>; else goto <bb 8>; <bb 7>: p_6_9 = p_6_1 + 1; <bb 8>: # p_6_10 = PHI <p_6_1(6), p_6_9(7)> <bb 9>: # p_6_1 = PHI <1(2), p_6_10(8)> if (p_6_1 <= 2) goto <bb 3>; else goto <bb 10>; to <bb 2>: goto <bb 9>; <bb 3>: p_6.0_3 = (int) p_6_2; if (p_6.0_3 <= 100) goto <bb 4>; else goto <bb 5>; <bb 4>: p_6_5 = p_6_2 >> p_6.0_3; <bb 5>: # p_6_12 = PHI <p_6_2(3), p_6_5(4)> if (p_6_12 != 0) goto <bb 10>; else goto <bb 6>; <bb 6>: if (p_6_12 <= 49) goto <bb 7>; else goto <bb 8>; <bb 7>: p_6_11 = p_6_12 + 1; <bb 8>: # p_6_4 = PHI <p_6_12(6), p_6_11(7)> <bb 9>: # p_6_2 = PHI <1(2), p_6_4(8)> if (p_6_2 <= 2) goto <bb 3>; else goto <bb 10>; see how p_6_9 = p_6_1 + 1 is changed to p_6_11 = p_6_12 + 1 forming an endless loop - it shuld have been p_6_11 = p_6_2 + 1 instead. Martin?
I have started a bootstrap and check of the following (with a testcase and change log and stuff...) which for some reason fixes this (renaming introduces the mess, the code as is generated by IPA-SRA is OK): Index: mine/gcc/tree-sra.c =================================================================== --- mine.orig/gcc/tree-sra.c +++ mine/gcc/tree-sra.c @@ -3478,7 +3478,10 @@ get_replaced_param_substitute (struct ip { char *pretty_name = make_fancy_name (adj->base); - repl = make_rename_temp (TREE_TYPE (adj->base), "ISR"); + repl = create_tmp_var (TREE_TYPE (adj->base), "ISR"); + if (TREE_CODE (TREE_TYPE (repl)) == COMPLEX_TYPE + || TREE_CODE (TREE_TYPE (repl)) == VECTOR_TYPE) + DECL_GIMPLE_REG_P (repl) = 1; DECL_NAME (repl) = get_identifier (pretty_name); obstack_free (&name_obstack, pretty_name);
Subject: Bug 42006 Author: jamborm Date: Fri Nov 27 22:34:40 2009 New Revision: 154715 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=154715 Log: 2009-11-27 Martin Jambor <mjambor@suse.cz> PR middle-end/42006 * tree-sra.c (get_replaced_param_substitute): Call create_tmp_var instead of create_tmp_var. Set DECL_GIMPLE_REG_P to one manually for vector and complex types. (get_adjustment_for_base): Describe return value in the comment. * testsuite/gcc.c-torture/execute/pr42006.c: New test. Added: trunk/gcc/testsuite/gcc.c-torture/execute/pr42006.c Modified: trunk/gcc/ChangeLog trunk/gcc/testsuite/ChangeLog trunk/gcc/tree-sra.c
Fixed.
Subject: Bug 42006 Author: hjl Date: Fri Dec 11 23:36:24 2009 New Revision: 155184 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=155184 Log: Backport testcases from trunk. 2009-12-11 H.J. Lu <hongjiu.lu@intel.com> Backport from mainline: 2009-12-11 Dodji Seketeli <dodji@redhat.com> PR c++/42225 * g++.dg/template/typedef24.C: New test. * g++.dg/template/typedef25.C: New test. 2009-12-11 Dodji Seketeli <dodji@redhat.com> PR c++/42251 * g++.dg/template/const3.C: New test. 2009-12-10 Jakub Jelinek <jakub@redhat.com> PR c++/42317 * g++.dg/opt/dtor2.C: New test. * g++.dg/opt/dtor2.h: New file. * g++.dg/opt/dtor2-aux.cc: New file. 2009-12-10 Jan Hubicka <jh@suse.cz> PR middle-end/42110 * g++.dg/torture/pr42110.C: new file. 2009-12-07 Jakub Jelinek <jakub@redhat.com> PR debug/42244 * gcc.dg/debug/pr42244.c: New test. 2009-12-04 David Daney <ddaney@caviumnetworks.com> PR rtl-optimization/42164 * gcc.c-torture/compile/pr42164.c: New test. 2009-12-03 Jason Merrill <jason@redhat.com> PR c++/41611 * g++.dg/abi/guard2.C: New. 2009-12-03 Dodji Seketeli <dodji@redhat.com> PR c++/42217 * g++.dg/other/bitfield4.C: New test. 2009-12-03 Jakub Jelinek <jakub@redhat.com> PR c++/42256 * g++.dg/inherit/thunk11.C: New test. * g++.dg/inherit/thunk11.h: New file. * g++.dg/inherit/thunk11-aux.cc: New file. 2009-12-01 Martin Jambor <mjambor@suse.cz> PR tree-optimization/42237 * gcc.c-torture/compile/pr42237.c: New test. 2009-12-01 Paolo Carlini <paolo.carlini@oracle.com> PR c++/42057 * g++.dg/parse/crash54.C: New. 2009-11-30 Martin Jambor <mjambor@suse.cz> PR middle-end/42196 * gcc.c-torture/compile/pr42196-1.c: New test. * gcc.c-torture/compile/pr42196-2.c: New test. * gcc.c-torture/compile/pr42196-3.c: New test. 2009-11-30 Dodji Seketeli <dodji@redhat.com> PR c++/42069 * g++.dg/template/typedef23.C: New test. 2009-11-29 H.J. Lu <hongjiu.lu@intel.com> PR tree-optimization/41961 * g++.dg/tree-ssa/pr41961.C: New. 2009-11-29 Ira Rosen <irar@il.ibm.com> PR tree-optimization/42193 * gcc.dg/vect/pr42193.c: New test. 2009-11-28 Richard Guenther <rguenther@suse.de> PR tree-optimization/42183 * g++.dg/torture/pr42183.C: New testcase. 2009-11-27 Martin Jambor <mjambor@suse.cz> PR middle-end/42006 * gcc.c-torture/execute/pr42006.c: New test. 2009-11-27 Michael Matz <matz@suse.de> PR rtl-optimization/42084 * gcc.dg/pr42084.c: New test. 2009-11-27 Michael Matz <matz@suse.de> PR c++/41906 * g++.dg/tree-ssa/pr41906.C: New testcase. 2009-11-26 Michael Matz <matz@suse.de> PR tree-optimization/41905 * g++.dg/tree-ssa/pr41905.C: New testcase. 2009-11-24 Richard Guenther <rguenther@suse.de> PR tree-optimization/42142 * gcc.c-torture/execute/pr42142.c: New testcase. 2009-11-24 Martin Jambor <mjambor@suse.cz> PR tree-optimization/42154 * gcc.c-torture/execute/pr42154.c: New test. 2009-11-21 Martin Jambor <mjambor@suse.cz> PR middle-end/42025 * gcc.c-torture/compile/pr42025-1.c: New test. * gcc.c-torture/compile/pr42025-2.c: New test. 2009-11-21 Jakub Jelinek <jakub@redhat.com> PR tree-optimization/42078 * gcc.dg/pr42078.c: New test. Added: branches/gcc-4_4-branch/gcc/testsuite/g++.dg/abi/guard2.C - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/abi/guard2.C branches/gcc-4_4-branch/gcc/testsuite/g++.dg/inherit/thunk11-aux.cc - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/inherit/thunk11-aux.cc branches/gcc-4_4-branch/gcc/testsuite/g++.dg/inherit/thunk11.C - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/inherit/thunk11.C branches/gcc-4_4-branch/gcc/testsuite/g++.dg/inherit/thunk11.h - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/inherit/thunk11.h branches/gcc-4_4-branch/gcc/testsuite/g++.dg/opt/dtor2-aux.cc - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/opt/dtor2-aux.cc branches/gcc-4_4-branch/gcc/testsuite/g++.dg/opt/dtor2.C - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/opt/dtor2.C branches/gcc-4_4-branch/gcc/testsuite/g++.dg/opt/dtor2.h - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/opt/dtor2.h branches/gcc-4_4-branch/gcc/testsuite/g++.dg/other/bitfield4.C - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/other/bitfield4.C branches/gcc-4_4-branch/gcc/testsuite/g++.dg/parse/crash54.C - copied unchanged from r155172, trunk/gcc/testsuite/g++.dg/parse/crash54.C branches/gcc-4_4-branch/gcc/testsuite/g++.dg/template/const3.C - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/template/const3.C branches/gcc-4_4-branch/gcc/testsuite/g++.dg/template/typedef23.C - copied unchanged from r155181, trunk/gcc/testsuite/g++.dg/template/typedef23.C branches/gcc-4_4-branch/gcc/testsuite/g++.dg/template/typedef24.C - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/template/typedef24.C branches/gcc-4_4-branch/gcc/testsuite/g++.dg/template/typedef25.C - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/template/typedef25.C branches/gcc-4_4-branch/gcc/testsuite/g++.dg/torture/pr42110.C - copied unchanged from r155170, trunk/gcc/testsuite/g++.dg/torture/pr42110.C branches/gcc-4_4-branch/gcc/testsuite/g++.dg/torture/pr42183.C - copied unchanged from r155181, trunk/gcc/testsuite/g++.dg/torture/pr42183.C branches/gcc-4_4-branch/gcc/testsuite/g++.dg/tree-ssa/pr41905.C - copied unchanged from r155182, trunk/gcc/testsuite/g++.dg/tree-ssa/pr41905.C branches/gcc-4_4-branch/gcc/testsuite/g++.dg/tree-ssa/pr41906.C - copied unchanged from r155182, trunk/gcc/testsuite/g++.dg/tree-ssa/pr41906.C branches/gcc-4_4-branch/gcc/testsuite/g++.dg/tree-ssa/pr41961.C - copied unchanged from r155181, trunk/gcc/testsuite/g++.dg/tree-ssa/pr41961.C branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/compile/pr42025-1.c - copied unchanged from r155182, trunk/gcc/testsuite/gcc.c-torture/compile/pr42025-1.c branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/compile/pr42025-2.c - copied unchanged from r155182, trunk/gcc/testsuite/gcc.c-torture/compile/pr42025-2.c branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/compile/pr42164.c - copied unchanged from r155170, trunk/gcc/testsuite/gcc.c-torture/compile/pr42164.c branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/compile/pr42196-1.c - copied unchanged from r155181, trunk/gcc/testsuite/gcc.c-torture/compile/pr42196-1.c branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/compile/pr42196-2.c - copied unchanged from r155181, trunk/gcc/testsuite/gcc.c-torture/compile/pr42196-2.c branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/compile/pr42196-3.c - copied unchanged from r155181, trunk/gcc/testsuite/gcc.c-torture/compile/pr42196-3.c branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/compile/pr42237.c - copied unchanged from r155171, trunk/gcc/testsuite/gcc.c-torture/compile/pr42237.c branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/execute/pr42006.c - copied unchanged from r155181, trunk/gcc/testsuite/gcc.c-torture/execute/pr42006.c branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/execute/pr42142.c - copied unchanged from r155182, trunk/gcc/testsuite/gcc.c-torture/execute/pr42142.c branches/gcc-4_4-branch/gcc/testsuite/gcc.c-torture/execute/pr42154.c - copied unchanged from r155182, trunk/gcc/testsuite/gcc.c-torture/execute/pr42154.c branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/debug/pr42244.c - copied unchanged from r155170, trunk/gcc/testsuite/gcc.dg/debug/pr42244.c branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/pr42078.c - copied unchanged from r155182, trunk/gcc/testsuite/gcc.dg/pr42078.c branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/pr42084.c - copied unchanged from r155182, trunk/gcc/testsuite/gcc.dg/pr42084.c branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/vect/pr42193.c - copied unchanged from r155181, trunk/gcc/testsuite/gcc.dg/vect/pr42193.c Modified: branches/gcc-4_4-branch/gcc/testsuite/ChangeLog