Bug 40704 - ^M? in testsuite log leads to binary attachment
Summary: ^M? in testsuite log leads to binary attachment
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: testsuite (show other bugs)
Version: 4.5.0
: P3 normal
Target Milestone: 4.5.0
Assignee: Not yet assigned to anyone
URL: http://gcc.gnu.org/ml/gcc-patches/200...
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-09 20:51 UTC by H.J. Lu
Modified: 2020-02-18 18:43 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description H.J. Lu 2009-07-09 20:51:14 UTC
Some gcc test results contain binary attachment:

http://gcc.gnu.org/ml/gcc-testresults/2009-07/msg00830.html

The problem is "^M?" in

                === libffi tests === 


Running target unix/-m32
XPASS: libffi.call/cls_dbls_struct.c -O0 -W -Wall output pattern test, 1.0 2.0^M?
XPASS: libffi.call/cls_dbls_struct.c -O2 output pattern test, 1.0 2.0^M?
XPASS: libffi.call/cls_dbls_struct.c -O3 output pattern test, 1.0 2.0^M?
XPASS: libffi.call/cls_dbls_struct.c -Os output pattern test, 1.0 2.0^M?
XPASS: libffi.call/cls_dbls_struct.c -O2 -fomit-frame-pointer output pattern test, 1.0 2.0^M?

                === libffi Summary for unix/-m32 === 

They come from

/* { dg-output "1.0 2.0\n" { xfail x86_64-*-linux-* } } */

in libffi.call/cls_dbls_struct.c.
Comment 1 Ben Elliston 2009-07-13 01:19:11 UTC
This is not LTO-specific, changing "Reported against" to 4.5.0.
Comment 2 H.J. Lu 2009-07-28 18:12:42 UTC
Shouldn't test_summary remove "^M?" when sending out emails?
Comment 3 Uroš Bizjak 2009-07-28 20:01:05 UTC
What about using ^ and $ throughout the testsuite instead of inventing regular expressions involving \n and \r in all possible combinations (i.e. (\n|\r\n|\r) )
Comment 4 H.J. Lu 2009-08-05 18:47:06 UTC
A patch is posted at

http://gcc.gnu.org/ml/gcc-patches/2009-08/msg00284.html
Comment 5 hjl@gcc.gnu.org 2009-08-18 19:41:06 UTC
Subject: Bug 40704

Author: hjl
Date: Tue Aug 18 19:40:48 2009
New Revision: 150898

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=150898
Log:
2009-08-18  H.J. Lu  <hongjiu.lu@intel.com>

	PR testsuite/40704
	* test_summary: Filter out "\r". 

Modified:
    trunk/contrib/ChangeLog
    trunk/contrib/test_summary

Comment 6 H.J. Lu 2009-09-28 15:48:21 UTC
Fixed.