Bug 40401 - [4.5 Regression] ICE: verify_gimple failed
Summary: [4.5 Regression] ICE: verify_gimple failed
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: c (show other bugs)
Version: 4.5.0
: P2 normal
Target Milestone: 4.5.0
Assignee: Richard Biener
URL:
Keywords: ice-checking, ice-on-valid-code, monitored
Depends on:
Blocks:
 
Reported: 2009-06-10 13:33 UTC by Ryan Mansfield
Modified: 2009-07-17 16:07 UTC (History)
4 users (show)

See Also:
Host: i686-pc-linux-gnu
Target: i686-pc-linux-gnu
Build: i686-pc-linux-gnu
Known to work:
Known to fail:
Last reconfirmed: 2009-07-09 15:38:32


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Mansfield 2009-06-10 13:33:01 UTC
$ cat /home/ryan/ice.i
typedef void (*malloc_error_fptr_t)(const char * const __file, unsigned int __lineno, const char * const __msg);
extern void (*_malloc_error)(const char *file, unsigned int lineno, const char *msg);

void _malloc_error_internal(const char * const fn);
malloc_error_fptr_t _malloc_error = _malloc_error_internal;

void malloc_abort(int status) {
        (*_malloc_error)("mprobe", 1, mcheck_error(status));
}


$ ./xgcc -B. ~/ice.i
/home/ryan/ice.i:5:1: warning: initialization from incompatible pointer type
/home/ryan/ice.i: In function âmalloc_abortâ:
/home/ryan/ice.i:8:2: warning: passing argument 3 of â_malloc_errorâ makes pointer from integer without a cast
/home/ryan/ice.i:8:2: note: expected âconst char * constâ but argument is of type âintâ
/home/ryan/ice.i:9:1: error: non-trivial conversion at assignment
void (*<T47e>) (const char * const, unsigned int, const char * const)
void (*<T481>) (const char *, unsigned int, const char *)
_malloc_error.0 = _malloc_error;

/home/ryan/ice.i:9:1: internal compiler error: verify_gimple failed
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

$ ./xgcc -B. -v
Reading specs from ./specs
Target: i686-pc-linux-gnu
Configured with: ../configure --enable-languages=c --disable-bootstrap
Thread model: posix
gcc version 4.5.0 20090610 (experimental) [trunk revision 148341] (GCC)
Comment 1 Volker Reichelt 2009-06-10 21:35:35 UTC
Confirmed. Even shorter testcase:

============================
void (*fp)(const int i);
void (*fp)(int i);

void foo()
{
  (*fp)(0);
}
============================

The regression appeared between 2009-04-24 and 2009-05-04.
Comment 2 Richard Biener 2009-06-13 13:57:18 UTC
Mine.
Comment 3 Richard Biener 2009-06-17 12:51:49 UTC
C frontend issue.

The gimplfier is fed (*fp)(0) with fp of type void (*) (const int) but then,
after gimplifying foo we do patch fps type to void (*) (int):

Hardware watchpoint 4: *$2

Old value = (tree) 0xb7d4e230
New value = (tree) 0xb7d4e310
0x080c80c6 in pop_scope () at /home/richard/src/trunk/gcc/c-decl.c:1225
1225			TREE_TYPE (b->shadowed->decl) = b->shadowed->u.type;
(gdb) bt
#0  0x080c80c6 in pop_scope () at /home/richard/src/trunk/gcc/c-decl.c:1225
#1  0x080c8501 in pop_file_scope ()
    at /home/richard/src/trunk/gcc/c-decl.c:1306
#2  0x08166df6 in c_common_parse_file (set_yydebug=0)
    at /home/richard/src/trunk/gcc/c-opts.c:1281
#3  0x08599792 in compile_file () at /home/richard/src/trunk/gcc/toplev.c:1025
#4  0x0859b61f in do_compile () at /home/richard/src/trunk/gcc/toplev.c:2345
#5  0x0859b6f8 in toplev_main (argc=3, argv=0xbffff534)
    at /home/richard/src/trunk/gcc/toplev.c:2390
#6  0x0819d96a in main (argc=153092128, argv=0x0)
    at /home/richard/src/trunk/gcc/main.c:35

that's not going to fly.

Maybe fixed with gimplification unit-at-a-time.
Comment 4 Richard Biener 2009-07-09 15:38:32 UTC
Indeed fixed by gimplifying unit-at-a-time.  Mine.
Comment 5 Richard Biener 2009-07-17 15:50:11 UTC
Subject: Bug 40401

Author: rguenth
Date: Fri Jul 17 15:49:34 2009
New Revision: 149750

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=149750
Log:
2009-07-17  Richard Guenther  <rguenther@suse.de>

	PR c/40401
	* tree-pass.h (pass_diagnose_omp_blocks): Declare.
	(pass_warn_unused_result): Likewise.
	(TODO_set_props): Remove.
	* omp-low.c (diagnose_omp_structured_block_errors): Change to
	run as a pass.
	(pass_diagnose_omp_blocks): Define.
	* c-decl.c (pop_file_scope): Do not finalize the CU here.
	(c_gimple_diagnostics_recursively): Remove.
	(finish_function): Do not call it.
	(c_write_global_declarations): Continue after errors.
	Finalize the CU here.
	* c-gimplify.c (c_genericize): Do not gimplify here.
	* c-common.c (c_warn_unused_result): Move ...
	* tree-cfg.c (do_warn_unused_result): ... here.
	(run_warn_unused_result): New function.
	(gate_warn_unused_result): New function.
	(pass_warn_unused_result): New pass.
	* c-common.h (c_warn_unused_result): Remove.
	* flags.h (flag_warn_unused_result): Declare.
	* c-opts.c (c_common_init_options): Enable flag_warn_unused_result.
	* opts.c (flag_warn_unused_result): Initialize to false.

	* toplev.c (compile_file): Add comment.
	* omp-low.c (create_omp_child_function): Do not register
	the function with the frontend.
	(diagnose_omp_structured_block_errors): Prepare to be
	called as optimization pass.
	(gate_diagnose_omp_blocks): New function.
	(pass_diagnose_omp_blocks): New pass.
	* cgraph.h (cgraph_optimize): Remove.
	(cgraph_analyze_function): Likewise.
	* cgraph.c (cgraph_add_new_function): Gimplify C++ thunks.
	* cgraphunit.c (cgraph_lower_function): Lower nested functions
	before their parents here.
	(cgraph_finalize_function): Not here.
	(cgraph_analyze_function): Gimplify functions here.
	(cgraph_finalize_compilation_unit): Continue after errors.
	Optimize the callgraph from here.
	(cgraph_optimize): Make static.
	* langhooks.c (write_global_declarations): Finalize the CU.
	* gimplify.c (gimplify_asm_expr): Do not emit ASMs with errors.
	(gimplify_function_tree): Assert we gimplify only once.
	Set PROP_gimple_any property.
	* tree-nested.c (gimplify_all_functions): New function.
	(lower_nested_functions): Gimplify all nested functions.
	* gimple.h (diagnose_omp_structured_block_errors): Remove.
	* passes.c (init_optimization_passes): Add pass_warn_unused_result
	and pass_diagnose_omp_blocks after gimplification.  Do not
	set TODO_set_props on all_lowering_passes.
	(execute_one_pass): Do not handle TODO_set_props.
	* Makefile.in (cgraphunit.o): Add $(TREE_DUMP_H) dependency.
	(gimplify.o): Add tree-pass.h dependency.
	* tree-inline.c (copy_statement_list): Properly copy STATEMENT_LIST.
	(copy_tree_body_r): Properly handle TARGET_EXPR like SAVE_EXPR.
	(unsave_r): Likewise.
	* c-omp.c (c_finish_omp_atomic): Set DECL_CONTEXT on the
	temporary variable.

	cp/
	* decl.c (finish_function): Do not emit unused result warnings
	from here.
	* cp-objcp-common.h (LANG_HOOKS_POST_GIMPLIFY_PASS): Use
	c_warn_unused_result_pass.
	* semantics.c (expand_or_defer_fn): Adjust assertion about IL status.
	* optimize.c (clone_body): Clone in GENERIC.
	(maybe_clone_body): Do not clear DECL_SAVED_TREE.
	* decl2.c (cp_write_global_declarations): Fix body test.
	Do not call cgraph_optimize.
	* Make-lang.in (optimize.o): Add tree-iterator.h dependency.
	* method.c (use_thunk): Register thunk with
	cgraph_finalize_function.
	* error.c (function_category): Guard access of DECL_LANG_SPECIFIC.

	java/
	* java-gimplify.c (java_genericize): Do not gimplify here.
	But replace all local references.
	(java_gimplify_expr): Do not replace local references here.
	(java_gimplify_modify_expr): Likewise.
	* jcf-parse.c (java_parse_file): Do not finalize the CU or
	optimize the cgraph here.
	* decl.c (java_replace_reference): Make static.
	(java_replace_references): New function.
	(end_java_method): Clear base_decl_map.
	* java-tree.h (java_replace_references): Declare.
	(java_replace_reference): Remove.

	ada/
	* utils.c (end_subprog_body): Revert to pre-tuples state.  Remove
	unused parameter.
	(gnat_gimplify_function): Do not gimplify here.
	Fold into its only caller and remove.
	(gnat_builtin_function): Adjust for end_subprog_body signature change.
	(gnat_write_global_declarations): Also finalize the CU.
	* misc.c (gnat_parse_file): Do not finalize the CU here.
	* trans.c (gigi): Revert to pre-tuples state.
	(Subprogram_Body_to_gnu): Adjust for end_subprog_body signature
	change.
	* gigi.h (end_subprog_body): Remove unused parameter.

	fortran/
	* f95-lang.c (gfc_be_parse_file): Do not finalize the CU here.
	* trans-decl.c (gfc_gimplify_function): Remove.
	(build_entry_thunks): Do not gimplify here.
	(create_main_function): Likewise.
	(gfc_generate_function_code): Likewise.

	* g++.dg/rtti/crash4.C: New testcase.
	* g++.dg/torture/20090706-1.C: Likewise.
	* gcc.dg/redecl-17.c: Likewise.

	* gfortran.dg/missing_optional_dummy_5.f90: Adjust pattern.
	* gcc.dg/declspec-9.c: Expect extra error.
	* gcc.dg/declspec-10.c: Likewise.
	* gcc.dg/declspec-11.c: Likewise.
	* gcc.dg/redecl-10.c: Expect extra warnings.
	* gcc.target/i386/pr39082-1.c: Adjust diagnostic location.
	* gcc.target/i386/pr39545-1.c: Likewise.
	* g++.dg/ext/asm3.C: Expect more errors.
	* g++.dg/gomp/block-1.C: Likewise.
	* g++.dg/gomp/block-2.C: Likewise.
	* g++.dg/gomp/block-3.C: Likewise.
	* g++.dg/gomp/block-5.C: Likewise.
	* g++.old-deja/g++.jason/report.C: Expect extra warnings.
	* g++.dg/warn/unused-result1.C: XFAIL.

Added:
    trunk/gcc/testsuite/g++.dg/rtti/crash4.C
    trunk/gcc/testsuite/g++.dg/torture/20090706-1.C
    trunk/gcc/testsuite/gcc.dg/redecl-17.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/Makefile.in
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/gcc-interface/gigi.h
    trunk/gcc/ada/gcc-interface/misc.c
    trunk/gcc/ada/gcc-interface/trans.c
    trunk/gcc/ada/gcc-interface/utils.c
    trunk/gcc/c-common.c
    trunk/gcc/c-common.h
    trunk/gcc/c-decl.c
    trunk/gcc/c-gimplify.c
    trunk/gcc/c-omp.c
    trunk/gcc/c-opts.c
    trunk/gcc/cgraph.c
    trunk/gcc/cgraph.h
    trunk/gcc/cgraphunit.c
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/Make-lang.in
    trunk/gcc/cp/decl.c
    trunk/gcc/cp/decl2.c
    trunk/gcc/cp/error.c
    trunk/gcc/cp/optimize.c
    trunk/gcc/cp/semantics.c
    trunk/gcc/flags.h
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/f95-lang.c
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/gimple.h
    trunk/gcc/gimplify.c
    trunk/gcc/java/ChangeLog
    trunk/gcc/java/decl.c
    trunk/gcc/java/java-gimplify.c
    trunk/gcc/java/java-tree.h
    trunk/gcc/java/jcf-parse.c
    trunk/gcc/langhooks.c
    trunk/gcc/omp-low.c
    trunk/gcc/opts.c
    trunk/gcc/passes.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/ext/asm3.C
    trunk/gcc/testsuite/g++.dg/gomp/block-1.C
    trunk/gcc/testsuite/g++.dg/gomp/block-2.C
    trunk/gcc/testsuite/g++.dg/gomp/block-3.C
    trunk/gcc/testsuite/g++.dg/gomp/block-5.C
    trunk/gcc/testsuite/g++.dg/warn/unused-result1.C
    trunk/gcc/testsuite/g++.old-deja/g++.jason/report.C
    trunk/gcc/testsuite/gcc.dg/declspec-10.c
    trunk/gcc/testsuite/gcc.dg/declspec-11.c
    trunk/gcc/testsuite/gcc.dg/declspec-9.c
    trunk/gcc/testsuite/gcc.dg/redecl-10.c
    trunk/gcc/testsuite/gcc.target/i386/pr39082-1.c
    trunk/gcc/testsuite/gcc.target/i386/pr39545-1.c
    trunk/gcc/testsuite/gfortran.dg/missing_optional_dummy_5.f90
    trunk/gcc/toplev.c
    trunk/gcc/tree-cfg.c
    trunk/gcc/tree-inline.c
    trunk/gcc/tree-nested.c
    trunk/gcc/tree-pass.h

Comment 6 Richard Biener 2009-07-17 16:07:30 UTC
Fixed.