Bug 40286 - mkinstalldirs in install-plugin target missing DESTDIR
Summary: mkinstalldirs in install-plugin target missing DESTDIR
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: bootstrap (show other bugs)
Version: 4.5.0
: P3 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-29 04:56 UTC by Ryan Hill
Modified: 2009-06-30 05:04 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2009-05-29 07:55:55


Attachments
gcc45-plugin-destdir.patch (294 bytes, patch)
2009-05-29 04:57 UTC, Ryan Hill
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Hill 2009-05-29 04:56:53 UTC
currently the install-plugin target creates directories in $(plugin_includedir).  this is broken wrt DESTDIR and causes a sandbox violation for us (we install into a sandboxed DESTDIR before merging with the live filesystem).  the attached patch was sent to gcc-patches but got no response, so i'm filing a PR.

I don't have a copyright assignment, but I'm thinking this counts as obvious.

https://bugs.gentoo.org/270558
Comment 1 Ryan Hill 2009-05-29 04:57:32 UTC
Created attachment 17930 [details]
gcc45-plugin-destdir.patch
Comment 2 Richard Biener 2009-05-29 07:55:55 UTC
Confirmed.
Comment 3 Matthias Klose 2009-06-22 11:20:04 UTC
updated patch: http://gcc.gnu.org/ml/gcc-patches/2009-06/msg01724.html
Comment 4 Matthias Klose 2009-06-22 15:35:24 UTC
fixed in rev 148806.
Comment 5 Ryan Hill 2009-06-30 05:04:20 UTC
Confirmed, thanks.