Bug 37218 - [4.4 Regression] Revision 139525 caused many SLP regressions
Summary: [4.4 Regression] Revision 139525 caused many SLP regressions
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: middle-end (show other bugs)
Version: 4.4.0
: P3 normal
Target Milestone: 4.4.0
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-24 02:46 UTC by H.J. Lu
Modified: 2008-08-25 16:33 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2008-08-24 08:39:43


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description H.J. Lu 2008-08-24 02:46:15 UTC
On Linux/ia32, Revision 139525 caused

FAIL: gcc.dg/vect/slp-14.c scan-tree-dump-times vect "vectorized 1 loops" 1
FAIL: gcc.dg/vect/slp-14.c scan-tree-dump-times vect "vectorizing stmts using SLP" 2
FAIL: gcc.dg/vect/slp-15.c scan-tree-dump-times vect "vectorized 1 loops" 1
FAIL: gcc.dg/vect/slp-15.c scan-tree-dump-times vect "vectorizing stmts using SLP" 2
FAIL: gcc.dg/vect/slp-2.c scan-tree-dump-times vect "vectorized 4 loops" 1
FAIL: gcc.dg/vect/slp-2.c scan-tree-dump-times vect "vectorizing stmts using SLP" 4
FAIL: gcc.dg/vect/slp-20.c scan-tree-dump-times vect "vectorized 2 loops" 1
FAIL: gcc.dg/vect/slp-20.c scan-tree-dump-times vect "vectorizing stmts using SLP" 4
FAIL: gcc.dg/vect/slp-22.c scan-tree-dump-times vect "vectorized 2 loops" 1
FAIL: gcc.dg/vect/slp-22.c scan-tree-dump-times vect "vectorizing stmts using SLP" 6
FAIL: gcc.dg/vect/slp-25.c scan-tree-dump-times vect "vectorized 2 loops" 1
FAIL: gcc.dg/vect/slp-25.c scan-tree-dump-times vect "Alignment of access forced using peeling" 2
FAIL: gcc.dg/vect/slp-9.c scan-tree-dump-times vect "vectorized 1 loops" 1
FAIL: gcc.dg/vect/slp-9.c scan-tree-dump-times vect "vectorizing stmts using SLP" 1
Comment 1 Richard Biener 2008-08-24 08:39:42 UTC
Well, it seems that revision included enabling ipa-cp by default at -O2 ;)

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=139525
Log:

	* ipa-cp.c (constant_val_insert): Remove.
	(ipcp_propagate_one_const): Remove.
	(ipcp_create_replace_map): Always insert replacements to the map.
	(ipcp_insert_stage): Do not try to insert statements by hand.
	* tree-inline.c (insert_init_stmt): Break out from ...
	(setup_one_parameter): ... here; allow NULL BB pointer.
	(tree_function_versioning): Use setup_one_parameter to process
	replacement map.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-cp.c
    trunk/gcc/opts.c
           ^^^^^^^^^^
    trunk/gcc/tree-inline.c


of course most of the vect tests are really written without optimizers
in mind ...
Comment 2 Dominique d'Humieres 2008-08-24 09:17:12 UTC
> Well, it seems that revision included enabling ipa-cp by default at -O2 ;)

May this explain the following failures (i686-apple-darwin9):

[ibook-dhum] f90/bug% gfc -O2 /opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/assumed_charlen_arg_1.f90
/opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/assumed_charlen_arg_1.f90: In function 'T.26':
/opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/assumed_charlen_arg_1.f90:3: internal compiler error: vector VEC(ipa_edge_args_t,base) index domain error, in ipa_edge_removal_hook at ipa-prop.c:1060
[ibook-dhum] f90/bug% gfc -O2 /opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/namelist_14.f90
/opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/namelist_14.f90: In function 'T.92':
/opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/namelist_14.f90:26: internal compiler error: in referenced_var_lookup, at tree-dfa.c:563
[ibook-dhum] f90/bug% gfc -O2 /opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/substr_4.f
/opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/substr_4.f: In function 'T.39':
/opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/substr_4.f:42: internal compiler error: in referenced_var_lookup, at tree-dfa.c:563

or should I open another PR?

Comment 3 Jan Hubicka 2008-08-24 11:37:16 UTC
Subject: Re:  [4.4 Regression] Revision 139525 caused many SLP regressions

> 
> or should I open another PR?

I've reverted the accidental commit as well as fixed this problem, so I
hope it is all OK.

Honza
Comment 4 H.J. Lu 2008-08-25 16:33:11 UTC
Fixed by revision 139532.