Bug 37149 - [4.4 Regression]: 27_io/basic_ostream/inserters_other/char/error_code.cc
Summary: [4.4 Regression]: 27_io/basic_ostream/inserters_other/char/error_code.cc
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: testsuite (show other bugs)
Version: 4.4.0
: P3 normal
Target Milestone: 4.4.0
Assignee: Paolo Carlini
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-18 15:21 UTC by Hans-Peter Nilsson
Modified: 2008-08-22 15:36 UTC (History)
1 user (show)

See Also:
Host: x86_64-unknown-linux-gnu
Target: cris-axis-elf
Build:
Known to work:
Known to fail:
Last reconfirmed: 2008-08-18 15:24:35

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans-Peter Nilsson 2008-08-18 15:21:56 UTC 
Worked with: 138952
Known to fail with: 138966 (and up to at least 139189)

Running /x/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp ...
...
FAIL: 27_io/basic_ostream/inserters_other/char/error_code.cc (test for excess errors)
WARNING: 27_io/basic_ostream/inserters_other/char/error_code.cc compilation failed to produce executable

.log:
/x/gcc/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_other/char/error_code.cc: In function 'void test()':

/x/gcc/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_other/char/error_code.cc:49: error: 'sprintf' was not declared in this scope


Apparently just a case of missing
#include <cstdio>
in the test-case.  A guess is that the libstdc++ configury change making GLIBCXX_CHECK_STDIO_MACROS unconditional caused it to fail, where it worked before.
Comment 1 Hans-Peter Nilsson 2008-08-18 15:24:35 UTC 
Trivial enough not to bother others...
Comment 2 Paolo Carlini 2008-08-18 15:37:49 UTC 
Ok, thanks, patch to include <cstdio> preapproved for mainline.
Comment 3 Paolo Carlini 2008-08-18 15:41:47 UTC 
Well, for 4_3-branch too, because the testcase is buggy anyway, you cannot assume any of the existing includes to bring in <cstdio>.
Comment 4 Paolo Carlini 2008-08-18 17:35:40 UTC 
Don't worry, I'm handling it together with a few other missing <cstdio>...
Comment 5 paolo@gcc.gnu.org 2008-08-18 17:49:06 UTC 
Subject: Bug 37149

Author: paolo
Date: Mon Aug 18 17:48:15 2008
New Revision: 139206

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=139206
Log:
2008-08-18  Paolo Carlini  <paolo.carlini@oracle.com>

	PR libstdc++/37149
	* testsuite/27_io/basic_ostream/inserters_other/char/4.cc: Include
	<cstdio>.
	* testsuite/27_io/basic_ostream/inserters_other/char/error_code.cc:
	Likewise.
	* testsuite/27_io/objects/char/12048-1.cc: Likewise.
	* testsuite/27_io/objects/char/12048-3.cc: Likewise.
	* testsuite/27_io/objects/wchar_t/12048-1.cc: Likewise.
	* testsuite/27_io/objects/wchar_t/12048-3.cc: Likewise.
	* testsuite/ext/malloc_allocator/deallocate_global.cc: Likewise.
	* testsuite/ext/malloc_allocator/deallocate_local.cc: Likewise.
	* testsuite/ext/mt_allocator/deallocate_global-2.cc: Likewise.
	* testsuite/ext/mt_allocator/deallocate_global-4.cc: Likewise.
	* testsuite/ext/mt_allocator/deallocate_global_thread-1.cc: Likewise.
	* testsuite/ext/mt_allocator/deallocate_global_thread-3.cc: Likewise.
	* testsuite/ext/mt_allocator/deallocate_local-2.cc: Likewise.
	* testsuite/ext/mt_allocator/deallocate_local-4.cc: Likewise.
	* testsuite/ext/mt_allocator/deallocate_local-6.cc: Likewise.
	* testsuite/ext/mt_allocator/deallocate_local-8.cc: Likewise.
	* testsuite/ext/mt_allocator/deallocate_local_thread-1.cc: Likewise.
	* testsuite/ext/mt_allocator/deallocate_local_thread-3.cc: Likewise.
	* testsuite/ext/mt_allocator/deallocate_local_thread-5.cc: Likewise.
	* testsuite/ext/mt_allocator/deallocate_local_thread-7.cc: Likewise.
	* testsuite/ext/new_allocator/deallocate_global.cc: Likewise.
	* testsuite/ext/new_allocator/deallocate_local.cc: Likewise.
	* testsuite/ext/stdio_sync_filebuf/wchar_t/12077.cc: Likewise.
	* include/std/regex: Include <sstream>.
	* include/tr1/regex: Likewise.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/std/regex
    trunk/libstdc++-v3/include/tr1/regex
    trunk/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_other/char/4.cc
    trunk/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_other/char/error_code.cc
    trunk/libstdc++-v3/testsuite/27_io/objects/char/12048-1.cc
    trunk/libstdc++-v3/testsuite/27_io/objects/char/12048-3.cc
    trunk/libstdc++-v3/testsuite/27_io/objects/wchar_t/12048-1.cc
    trunk/libstdc++-v3/testsuite/27_io/objects/wchar_t/12048-3.cc
    trunk/libstdc++-v3/testsuite/ext/malloc_allocator/deallocate_global.cc
    trunk/libstdc++-v3/testsuite/ext/malloc_allocator/deallocate_local.cc
    trunk/libstdc++-v3/testsuite/ext/mt_allocator/deallocate_global-2.cc
    trunk/libstdc++-v3/testsuite/ext/mt_allocator/deallocate_global-4.cc
    trunk/libstdc++-v3/testsuite/ext/mt_allocator/deallocate_global_thread-1.cc
    trunk/libstdc++-v3/testsuite/ext/mt_allocator/deallocate_global_thread-3.cc
    trunk/libstdc++-v3/testsuite/ext/mt_allocator/deallocate_local-2.cc
    trunk/libstdc++-v3/testsuite/ext/mt_allocator/deallocate_local-4.cc
    trunk/libstdc++-v3/testsuite/ext/mt_allocator/deallocate_local-6.cc
    trunk/libstdc++-v3/testsuite/ext/mt_allocator/deallocate_local-8.cc
    trunk/libstdc++-v3/testsuite/ext/mt_allocator/deallocate_local_thread-1.cc
    trunk/libstdc++-v3/testsuite/ext/mt_allocator/deallocate_local_thread-3.cc
    trunk/libstdc++-v3/testsuite/ext/mt_allocator/deallocate_local_thread-5.cc
    trunk/libstdc++-v3/testsuite/ext/mt_allocator/deallocate_local_thread-7.cc
    trunk/libstdc++-v3/testsuite/ext/new_allocator/deallocate_global.cc
    trunk/libstdc++-v3/testsuite/ext/new_allocator/deallocate_local.cc
    trunk/libstdc++-v3/testsuite/ext/stdio_sync_filebuf/wchar_t/12077.cc
Comment 6 Paolo Carlini 2008-08-18 17:50:45 UTC 
Fixed.
Comment 7 Richard Biener 2008-08-22 15:36:01 UTC 
So, fixed.