> gcc/ChangeLog: > 2008-02-17 Ralf Wildenhues <Ralf.Wildenhues@gmx.de> > > PR bootstrap/35218 > * Makefile.in (build_file_translate): New. > (gcc-vers.texi): Use it for translating $(abs_srcdir). > * config.build (build_file_translate): Set to `CMD //c' on MinGW. > * configure.ac (build_file_translate): Substitute it. > * configure: Regenerate. > This patch breaks native bootstrap on mingw systems that use cygwin1.dll-dependent bash and development tools. As such, that would be a regression against all versions of gcc since at least 2.95.3 I did not see an approval of this patch in GCC-patches. Was it approved off-line? The ' CMD //c' (with 2 slashes preceding the switch rather than the one documented for cmd by Micrsosoft) is a MSYS-ism that causes problems with non-MSYS shells (including cygwin bash, ZSH, and the shell provided by MS in its SFU package) Prior to this patch, GCC bootstrapped just fine (with or without the earlier abs_srcdir patch that broke MSYS build) on mingw using the cygwin bash shell, make and configure. Using cygwin shell rather than the MSYS shell means that DejaGnu testsuite can be run. The last time I checked this was not possible with MSYS. Danny
Fix typo in summary
(In reply to comment #0) > I did not see an approval of this patch in GCC-patches. Was it approved > off-line? Yes, it was approved by Jakub. Patch to fix this breakage posted at <http://gcc.gnu.org/ml/gcc-patches/2008-02/msg00877.html>.
> Yes, it was approved by Jakub. To be precise, approved by Paolo in http://gcc.gnu.org/ml/gcc/2008-02/msg00410.html and acked for 4.3 by me. Anyway, AFAIK the http://gcc.gnu.org/ml/gcc-patches/2008-02/msg00877.html patch was approved by Paolo too, can one of you please commit that to the trunk/4.3? branch?
Subject: Bug 35273 Author: rwild Date: Thu Feb 21 19:55:39 2008 New Revision: 132528 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132528 Log: PR bootstrap/35273 * config.build (build_file_translate): Set to `CMD //c' only if it works. * Makefile.in (build_file_translate): Improve comment. Modified: trunk/gcc/ChangeLog trunk/gcc/Makefile.in trunk/gcc/config.build
Subject: Bug 35273 Author: rwild Date: Thu Feb 21 19:56:23 2008 New Revision: 132529 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132529 Log: PR bootstrap/35273 * config.build (build_file_translate): Set to `CMD //c' only if it works. * Makefile.in (build_file_translate): Improve comment. Modified: branches/gcc-4_3-branch/gcc/ChangeLog branches/gcc-4_3-branch/gcc/Makefile.in branches/gcc-4_3-branch/gcc/config.build
Subject: Bug 35273 Author: rwild Date: Thu Feb 21 20:05:11 2008 New Revision: 132530 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132530 Log: PR bootstrap/35273 * config.build (build_file_translate): Set to `CMD //c' only if it works. * Makefile.in (build_file_translate): Improve comment. Modified: branches/gcc-4_2-branch/gcc/ChangeLog branches/gcc-4_2-branch/gcc/Makefile.in branches/gcc-4_2-branch/gcc/config.build
(In reply to comment #3) > > Yes, it was approved by Jakub. > > To be precise, approved by Paolo in > http://gcc.gnu.org/ml/gcc/2008-02/msg00410.html > and acked for 4.3 by me. Yes, sorry for being imprecise. > Anyway, AFAIK the http://gcc.gnu.org/ml/gcc-patches/2008-02/msg00877.html patch > was approved by Paolo too, can one of you please commit that to the trunk/4.3? > branch? Yes, done now. Also to 4.2 branch because it had the same problem (I understand for that branch I don't need RM ack, and the patch was approved for this branch). I also improved the comment in Makefile.in as suggested by Danny.