Bug 34821 - [4.3 regression] new gcc.dg testsuite failures
Summary: [4.3 regression] new gcc.dg testsuite failures
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: testsuite (show other bugs)
Version: 4.3.0
: P2 normal
Target Milestone: 4.3.0
Assignee: Sebastian Pop
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-16 22:12 UTC by Hans-Peter Nilsson
Modified: 2008-01-17 18:01 UTC (History)
2 users (show)

See Also:
Host: x86_64-unknown-linux-gnu
Target: cris-elf
Build:
Known to work:
Known to fail:
Last reconfirmed: 2008-01-16 23:04:18


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hans-Peter Nilsson 2008-01-16 22:12:32 UTC
Before revision 131573 these tests passed. With revision 131577, these tests fail.
Running /tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.dg/tree-ssa/tree-ssa.exp ...
FAIL: gcc.dg/tree-ssa/parallelization-1.c (test for excess errors)
FAIL: gcc.dg/tree-ssa/reduc-1.c (test for excess errors)
FAIL: gcc.dg/tree-ssa/reduc-1char.c (test for excess errors)
FAIL: gcc.dg/tree-ssa/reduc-1short.c (test for excess errors)
FAIL: gcc.dg/tree-ssa/reduc-2.c (test for excess errors)
FAIL: gcc.dg/tree-ssa/reduc-2char.c (test for excess errors)
FAIL: gcc.dg/tree-ssa/reduc-2short.c (test for excess errors)
FAIL: gcc.dg/tree-ssa/reduc-3.c (test for excess errors)
FAIL: gcc.dg/tree-ssa/reduc-6.c (test for excess errors)
FAIL: gcc.dg/tree-ssa/reduc-7.c (test for excess errors)
FAIL: gcc.dg/tree-ssa/reduc-8.c (test for excess errors)
FAIL: gcc.dg/tree-ssa/reduc-9.c (test for excess errors)
...
Running /tmp/hpautotest-gcc1/gcc/gcc/testsuite/g++.dg/dg.exp ...
...
FAIL: g++.dg/tree-ssa/pr34355.C (test for excess errors)

Authors of suspect patches CC:ed.
Comment 1 Hans-Peter Nilsson 2008-01-16 23:04:18 UTC
The .logs show that the failing tests error with:
xgcc: unrecognized option '-pthread'

That's because cris-elf does not support pthreads (being a bare-iron/simulator target).

The bug is due to spop's patch below; it shouldn't require pthread support.  Alternatively, the tests should be adjusted to require pthread support.
(Adjusting cc-list as the fault is now localized.)

Index: gcc/gcc.c
===================================================================
--- gcc/gcc.c   (revision 131573)
+++ gcc/gcc.c   (revision 131577)
@@ -721,7 +721,7 @@ proper position among the other output f
     %(linker) %l " LINK_PIE_SPEC "%X %{o*} %{A} %{d} %{e*} %{m} %{N} %{n} %{r}\
     %{s} %{t} %{u*} %{x} %{z} %{Z} %{!A:%{!nostdlib:%{!nostartfiles:%S}}}\
     %{static:} %{L*} %(mfwrap) %(link_libgcc) %o\
-    %{fopenmp:%:include(libgomp.spec)%(link_gomp)} %(mflib)\
+    %{fopenmp|ftree-parallelize-loops=*:%:include(libgomp.spec)%(link_gomp)} %(mflib)\
     %{fprofile-arcs|fprofile-generate|coverage:-lgcov}\
     %{!nostdlib:%{!nodefaultlibs:%(link_ssp) %(link_gcc_c_sequence)}}\
     %{!A:%{!nostdlib:%{!nostartfiles:%E}}} %{T*} }}}}}}"
@@ -870,7 +870,7 @@ static const char *const multilib_defaul
 /* Adding -fopenmp should imply pthreads.  This is particularly important
    for targets that use different start files and suchlike.  */
 #ifndef GOMP_SELF_SPECS
-#define GOMP_SELF_SPECS "%{fopenmp: -pthread}"
+#define GOMP_SELF_SPECS "%{fopenmp|ftree-parallelize-loops=*: -pthread}"
 #endif

 static const char *const driver_self_specs[] = {
Comment 2 Hans-Peter Nilsson 2008-01-17 10:09:00 UTC
Changed component as it was a documentation+testsuite mishap.
Comment 3 Sebastian Pop 2008-01-17 17:55:40 UTC
Subject: Bug 34821

Author: spop
Date: Thu Jan 17 17:54:56 2008
New Revision: 131605

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131605
Log:
2008-01-17  Sebastian Pop  <sebastian.pop@amd.com>

	PR testsuite/34821
	* gcc.dg/autopar/autopar.exp: New.
	* g++.dg/tree-ssa/pr34355.C: Require pthread.
	* lib/target-supports.exp (check_effective_target_pthread): New.

	* gcc.dg/tree-ssa/parallelization-1.c: Moved to gcc.dg/autopar.
	* gcc.dg/tree-ssa/reduc-1short.c: Same.
	* gcc.dg/tree-ssa/reduc-1.c: Same.
	* gcc.dg/tree-ssa/reduc-2short.c: Same.
	* gcc.dg/tree-ssa/reduc-2.c: Same
	* gcc.dg/tree-ssa/reduc-3.c: Same.
	* gcc.dg/tree-ssa/reduc-1char.c: Same.
	* gcc.dg/tree-ssa/reduc-6.c: Same.
	* gcc.dg/tree-ssa/reduc-7.c: Same.
	* gcc.dg/tree-ssa/reduc-2char.c: Same.
	* gcc.dg/tree-ssa/reduc-8.c: Same.
	* gcc.dg/tree-ssa/reduc-9.c: Same.


Added:
    trunk/gcc/testsuite/gcc.dg/autopar/
    trunk/gcc/testsuite/gcc.dg/autopar/autopar.exp
    trunk/gcc/testsuite/gcc.dg/autopar/parallelization-1.c
      - copied unchanged from r131577, trunk/gcc/testsuite/gcc.dg/tree-ssa/parallelization-1.c
    trunk/gcc/testsuite/gcc.dg/autopar/reduc-1.c
      - copied unchanged from r131577, trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-1.c
    trunk/gcc/testsuite/gcc.dg/autopar/reduc-1char.c
      - copied unchanged from r131577, trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-1char.c
    trunk/gcc/testsuite/gcc.dg/autopar/reduc-1short.c
      - copied unchanged from r131577, trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-1short.c
    trunk/gcc/testsuite/gcc.dg/autopar/reduc-2.c
      - copied unchanged from r131577, trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-2.c
    trunk/gcc/testsuite/gcc.dg/autopar/reduc-2char.c
      - copied unchanged from r131577, trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-2char.c
    trunk/gcc/testsuite/gcc.dg/autopar/reduc-2short.c
      - copied unchanged from r131577, trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-2short.c
    trunk/gcc/testsuite/gcc.dg/autopar/reduc-3.c
      - copied unchanged from r131577, trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-3.c
    trunk/gcc/testsuite/gcc.dg/autopar/reduc-6.c
      - copied unchanged from r131577, trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-6.c
    trunk/gcc/testsuite/gcc.dg/autopar/reduc-7.c
      - copied unchanged from r131577, trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-7.c
    trunk/gcc/testsuite/gcc.dg/autopar/reduc-8.c
      - copied unchanged from r131577, trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-8.c
    trunk/gcc/testsuite/gcc.dg/autopar/reduc-9.c
      - copied unchanged from r131577, trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-9.c
Removed:
    trunk/gcc/testsuite/gcc.dg/tree-ssa/parallelization-1.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-1.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-1char.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-1short.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-2.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-2char.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-2short.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-3.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-6.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-7.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-8.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/reduc-9.c
Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/tree-ssa/pr34355.C
    trunk/gcc/testsuite/lib/target-supports.exp

Comment 4 Sebastian Pop 2008-01-17 18:01:25 UTC
Subject: Bug 34821

Author: spop
Date: Thu Jan 17 18:00:41 2008
New Revision: 131606

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131606
Log:
2008-01-16  Sebastian Pop  <sebastian.pop@amd.com>

	PR testsuite/34821
	* doc/invoke.texi: Document the dependence on pthread for fopenmp
	and ftree-parallelize-loops.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/doc/invoke.texi

Comment 5 Sebastian Pop 2008-01-17 18:01:28 UTC
Fixed.