Bug 32603 - Sibcall optimization fails to detect non-overlapping arguments
Summary: Sibcall optimization fails to detect non-overlapping arguments
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: middle-end (show other bugs)
Version: 4.3.0
: P3 normal
Target Milestone: 4.3.0
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-02 23:27 UTC by Joshua Conner
Modified: 2009-01-01 05:52 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Conner 2007-07-02 23:27:13 UTC
The following code, compiled for arm-none-elf at -O2:

~~~~~~~~~~

#define noinline __attribute__((noinline))

typedef struct {
  int data[4];
} arr16_t;

int result = 0;

void noinline func2 (int i, int j, arr16_t arr)
{
  result = (arr.data[0] != 1
	    || arr.data[1] != 2
	    || arr.data[2] != 3
	    || arr.data[3] != 4);
}

void func1 (int i, int j, int k, int l, int m, int n, arr16_t a)
{
  func2(i, j, a);
}

int main(int argc, const char *argv[])
{
  arr16_t arr = {{1, 2, 3, 4}};
    
  func1(0, 0, 0, 0, 0, 0, arr);
  return result;
}

~~~~~~~~~~

The call to func2 should be optimized into a sibcall, however store_one_arg() is preventing it because it incorrectly identifies the arr16_t coming into func1 as overlapping on the stack where it needs to put the outgoing arr16_t for the call to func2.  In fact, the incoming arg only uses [SP,SP+7] (the other two words are passed in registers) and the outgoing arg uses [SP+8,SP+23].
Comment 1 Joshua Conner 2007-07-02 23:28:54 UTC
I have a patch which addresses this (and pr32602) -- I will submit it shortly.
Comment 2 jconner 2007-07-06 16:57:31 UTC
Subject: Bug 32603

Author: jconner
Date: Fri Jul  6 16:57:19 2007
New Revision: 126422

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=126422
Log:
2007-07-06  Josh Conner  <jconner@apple.com>

	PR middle-end/32602
	PR middle-end/32603
	* calls.c (store_one_arg): Handle arguments which are partially
	on the stack when detecting argument overlap.

2007-07-06  Josh Conner  <jconner@apple.com>

	PR middle-end/32602
	* gcc.dg/sibcall-8.c: New test.

2007-07-06  Josh Conner  <jconner@apple.com>

	PR middle-end/32603
	* gcc.target/arm/sibcall-1.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/sibcall-8.c
    trunk/gcc/testsuite/gcc.target/arm/sibcall-1.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/calls.c
    trunk/gcc/testsuite/ChangeLog

Comment 3 Andrew Pinski 2009-01-01 05:52:33 UTC
Fixed.