Bug 3120 - __builtin_fsqrt still on mainline
Summary: __builtin_fsqrt still on mainline
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: c (show other bugs)
Version: 3.1
: P3 normal
Target Milestone: 3.1.x/3.2.x
Assignee: Gabriel Dos Reis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-06-11 02:26 UTC by Joseph S. Myers
Modified: 2005-04-20 02:38 UTC (History)
3 users (show)

See Also:
Host: i686-pc-linux-gnu
Target: i686-pc-linux-gnu
Build: i686-pc-linux-gnu
Known to work:
Known to fail:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph S. Myers 2001-06-11 02:26:00 UTC
The mainline still has __builtin_fsqrt, where the 3.0 branch changed
to __builtin_sqrt.  This sort of regression from branch to mainline
should be avoided - but has been present since the 28th of May.

http://gcc.gnu.org/ml/gcc-patches/2001-06/msg00394.html

Release:
3.1 20010609 (experimental)

Environment:
System: Linux digraph 2.2.19 #1 Wed Mar 28 16:01:38 UTC 2001 i686 unknown
Architecture: i686

	
host: i686-pc-linux-gnu
build: i686-pc-linux-gnu
target: i686-pc-linux-gnu
configured with: ../gcc-cvs/configure --prefix=/opt/gcc/mainline --disable-shared --enable-threads=posix --with-system-zlib

How-To-Repeat:
Work on the GCC manual and observe a bogus difference
branch-to-mainline, because this patch (including the doc changes) has
not been applied to the mainline.
Comment 1 Joseph S. Myers 2001-06-11 02:26:00 UTC
Fix:
Adapt http://gcc.gnu.org/ml/gcc-patches/2001-05/msg01939.html for the
mainline and apply it.
Comment 2 Joseph S. Myers 2001-06-22 03:33:30 UTC
Responsible-Changed-From-To: unassigned->gdr
Responsible-Changed-Why: You applied the patch to branch only.
Comment 3 Joseph S. Myers 2001-06-22 03:33:30 UTC
State-Changed-From-To: open->analyzed
State-Changed-Why: Confirming my PR.  This is a regression from 3.0 to the
    mainline.
Comment 4 Andreas Jaeger 2001-12-14 13:07:51 UTC
State-Changed-From-To: analyzed->closed
State-Changed-Why: This bug has been fixed by a patch from Roger that has
    just been committed to CVS,
    
    Thanks for the report,
    Andreas
    
    2001-12-14  Roger Sayle <roger@eyesopen.com>
    	* builtins.def: Rename BUILT_IN_FSQRT to BUILT_IN_SQRT and
    	__builtin_fsqrt to __builtin_sqrt.
    	* builtins.c (expand_builtin_mathfn,expand_builtin): Same.
    	* doc/extend.texi: Simplify documentation to match patch.
    
    	* f/com-rt.def: Use __builtin_sqrt instead of __builtin_fsqrt.
    	* f/com.c (ffecom_init_0): Same, and fixed enumeration usage.
    
    	* libstdc++-v3/acconfig.h: Test for __builtin_sqrt instead of
    	__builtin_fsqrt.
    	* libstdc++-v3/acinclude.m4: Same.
    	* libstdc++-v3/include/c_shadow/bits/std_cmath.h: Same.