Bug 29033 - %s substituted with "left"/"right" can't be properly translated
Summary: %s substituted with "left"/"right" can't be properly translated
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: c++ (show other bugs)
Version: 4.1.0
: P3 minor
Target Milestone: 4.3.0
Assignee: Dirk Mueller
URL:
Keywords: diagnostic
Depends on:
Blocks:
 
Reported: 2006-09-12 12:07 UTC by Göran Uddeborg
Modified: 2006-10-28 22:41 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Known to work: 4.3.0
Known to fail:
Last reconfirmed: 2006-09-12 15:15:28

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Göran Uddeborg 2006-09-12 12:07:57 UTC 
In gcc/cp/typeck.c there is this code.

	      if (tree_int_cst_lt (op1, integer_zero_node))
		warning (0, "%s rotate count is negative",
			 (code == LROTATE_EXPR) ? "left" : "right");
	      else if (compare_tree_int (op1, TYPE_PRECISION (type0)) >= 0)
		warning (0, "%s rotate count >= width of type",
			 (code == LROTATE_EXPR) ? "left" : "right");

Here "left" and "right" will not be translated.  So it is not possible to do a correct translation of these messages.
Comment 1 Richard Biener 2006-09-12 15:15:28 UTC 
Confirmed.  Easiest is to simply remove distinguishing between left and right.
Comment 2 Dirk Mueller 2006-10-28 22:34:15 UTC 
Subject: Bug 29033

Author: mueller
Date: Sat Oct 28 22:34:06 2006
New Revision: 118117

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=118117
Log:
2006-10-29  Dirk Mueller  <dmueller@suse.de>

       PR c++/29033
      * typeck.c (build_binary_op): Duplicate warning message
       for better translation.


Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/typeck.c
Comment 3 Dirk Mueller 2006-10-28 22:41:58 UTC 
Fixed for 4.3.