Bug 26863 - Invalid XML in gnu.java.util.prefs.NodeWriter.writeRoot()
Summary: Invalid XML in gnu.java.util.prefs.NodeWriter.writeRoot()
Status: RESOLVED FIXED
Alias: None
Product: classpath
Classification: Unclassified
Component: classpath (show other bugs)
Version: 0.90
: P3 normal
Target Milestone: 0.91
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-25 03:16 UTC by John K Peterson
Modified: 2006-04-27 12:13 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John K Peterson 2006-03-25 03:16:19 UTC
This code has a slash at the end of the opening <root> tag, but also has a closing </root> tag.

    private void writeRoot() throws BackingStoreException, IOException {
        bw.write("  <root type=\"");
        if (prefs.isUserNode()) {
            bw.write("user"); 
        } else {
            bw.write("system");
        }
        bw.write("\"/>");
            
        writeRootMap();
        writeNode();
        
        bw.write("  </root>");
        bw.newLine();
    }
Comment 1 Mark Wielaard 2006-03-25 09:42:46 UTC
Fix checked in. Thanks for the report.
Comment 2 cvs-commit@developer.classpath.org 2006-03-25 09:44:27 UTC
Subject: Bug 26863

CVSROOT:	/cvsroot/classpath
Module name:	classpath
Branch: 	
Changes by:	Mark Wielaard <mark@savannah.gnu.org>	06/03/25 09:42:11

Modified files:
	.              : ChangeLog 
	gnu/java/util/prefs: NodeWriter.java 

Log message:
	Fixes bug #26863 reported by John K Peterson <johnandtina@byu.net>
	* gnu/java/util/prefs/NodeWriter.java (writeRoot): Don't immediately
	close root tag.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.6887&tr2=1.6888&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/gnu/java/util/prefs/NodeWriter.java.diff?tr1=1.4&tr2=1.5&r1=text&r2=text