Bug 25865 - [4.2 Regression] libgomp incorrectly detects support for TLS
Summary: [4.2 Regression] libgomp incorrectly detects support for TLS
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: libgomp (show other bugs)
Version: 4.2.0
: P3 normal
Target Milestone: 4.2.0
Assignee: Richard Henderson
URL:
Keywords: build
: 27179 (view as bug list)
Depends on:
Blocks: 25925 27179
  Show dependency tree / graph
 
Reported: 2006-01-20 00:47 UTC by Richard Earnshaw
Modified: 2006-04-25 21:03 UTC (History)
6 users (show)

See Also:
Host:
Target: *-*-netbsd, sparc64-portbld-freebsd6.1
Build:
Known to work:
Known to fail:
Last reconfirmed: 2006-04-25 20:54:06

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Earnshaw 2006-01-20 00:47:34 UTC 
acinclude.m4 has a home-brewed rule to detect whether a target can support TLS.  This rule incorrectly decides that NetBSD can support this.  The result is that libgomp will not load, and faults with the error:
Unsupported relocation type 14 in non-PLT relocations

Rather than rolling its own rule, it should be using the rule in $(topsrcdir)/config/tls.m4 -- namely GCC_CHECK_TLS.
Comment 1 Andrew Pinski 2006-01-25 20:42:16 UTC 
Confirmed.
Comment 2 Andrew Pinski 2006-04-20 23:47:36 UTC 
*** Bug 27179 has been marked as a duplicate of this bug. ***
Comment 3 Andrew Pinski 2006-04-20 23:48:26 UTC 
This also effects sparc64-portbld-freebsd6.1 as described in PR 27179.
Comment 4 Christian Joensson 2006-04-24 09:26:06 UTC 
I understand that this might be affecting SPARC/Linux too, cf., http://gcc.gnu.org/ml/gcc/2006-04/msg00448.html
Comment 5 Richard Henderson 2006-04-25 20:58:33 UTC 
Subject: Bug 25865

Author: rth
Date: Tue Apr 25 20:58:25 2006
New Revision: 113256

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=113256
Log:
        PR libgomp/25865
        * configure.ac: Use GCC_CHECK_TLS.
        * acinclude.m4 (LIBGOMP_CHECK_TLS): Remove.
        * Makefile.in, aclocal.m4, configure: Regenerate.

Modified:
    trunk/libgomp/ChangeLog
    trunk/libgomp/Makefile.in
    trunk/libgomp/acinclude.m4
    trunk/libgomp/aclocal.m4
    trunk/libgomp/configure
    trunk/libgomp/configure.ac
    trunk/libgomp/testsuite/Makefile.in
Comment 6 Richard Henderson 2006-04-25 21:03:14 UTC 
Fixed, or if not, moved the point of failure out of libgomp.