Bug 25590 - [4.1/4.2 regression] FAIL: gcc.dg/tree-ssa/gen-vect-11.c scan-tree-dump-times vectorized 1 loops 1
Summary: [4.1/4.2 regression] FAIL: gcc.dg/tree-ssa/gen-vect-11.c scan-tree-dump-times...
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: testsuite (show other bugs)
Version: 4.2.0
: P3 normal
Target Milestone: 4.1.0
Assignee: Kazu Hirata
URL: http://gcc.gnu.org/ml/gcc-patches/200...
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-28 16:08 UTC by John David Anglin
Modified: 2006-01-25 16:11 UTC (History)
4 users (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2005-12-28 16:30:59


Attachments
tree dump (679 bytes, text/plain)
2005-12-28 16:15 UTC, John David Anglin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John David Anglin 2005-12-28 16:08:04 UTC
Executing on host: /home/dave/gcc-4.2/objdir/gcc/xgcc -B/home/dave/gcc-4.2/objdi
r/gcc/ /home/dave/gcc-4.2/gcc/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-11.c   -O2
-ftree-vectorize -ftree-vectorizer-verbose=3 -fdump-tree-vect-stats -fno-show-co
lumn  -lm   -o ./gen-vect-11.exe    (timeout = 300)
PASS: gcc.dg/tree-ssa/gen-vect-11.c (test for excess errors)
Setting LD_LIBRARY_PATH to :/home/dave/gcc-4.2/objdir/gcc::/home/dave/gcc-4.2/ob
jdir/gcc:/home/dave/gcc-4.2/objdir/hppa-linux/libstdc++-v3/.libs:/home/dave/gcc-
4.2/objdir/hppa-linux/libmudflap/.libs:/home/dave/gcc-4.2/objdir/hppa-linux/libs
sp/.libs:/home/dave/gcc-4.2/objdir/./gcc:/home/dave/gcc-4.2/objdir/./prev-gcc
PASS: gcc.dg/tree-ssa/gen-vect-11.c execution test
FAIL: gcc.dg/tree-ssa/gen-vect-11.c scan-tree-dump-times vectorized 1 loops 1

Fails on both hppa-unknown-linux-gnu and hppa2.0w-hp-hpux11.11.
Comment 1 John David Anglin 2005-12-28 16:15:33 UTC
Created attachment 10561 [details]
tree dump
Comment 2 Andrew Pinski 2005-12-28 16:20:17 UTC
I noticed this on x86_64 also.
Comment 3 Andrew Pinski 2005-12-28 16:30:59 UTC
Confirmed, just a missing XFAIL as we have unsigned char + unsigned char which gets changed to (int)(unsigned char)+(int)(unsigned char) after Kazu's patch:
2005-12-26  Kazu Hirata  <kazu@codesourcery.com>

        PR tree-optimization/25125
        * convert.c (convert_to_integer): Don't narrow the type of a
        PLUX_EXPR or MINUS_EXPR if !flag_wrapv and the unwidened type
        is signed.
Comment 4 Hans-Peter Nilsson 2006-01-04 00:50:34 UTC
Where it used to work for 108426 I see this for 109236
on (cross from i686-pc-linux-gnu FC2 unless otherwise noted):
mips-elf
sh-elf
i686-pc-linux-gnu (native, FC2)
cris-axis-linux-gnu
cris-axis-elf
mmix-knuth-mmixware
Comment 5 Joseph S. Myers 2006-01-04 01:08:03 UTC
Appeared between 109012 and 109267 on i686-pc-linux-gnu, hppa2.0w-hp-hpux11.11, hppa64-hp-hpux11.11.
Comment 6 Dorit Naishlos 2006-01-04 07:33:45 UTC
Maybe related to:

2005-12-26  Kazu Hirata  <kazu@codesourcery.com>

        PR tree-optimization/25125
        * convert.c (convert_to_integer): Don't narrow the type of a
        PLUX_EXPR or MINUS_EXPR if !flag_wrapv and the unwidened type
        is signed.

(indeed this testcase fails vectorization due to cast to unsigned char).
If that's the case, it should probably be xfailed and the PR should be "missed optimization"
Comment 7 Dorit Naishlos 2006-01-04 07:36:35 UTC
(sorry, didn't notice it was already diagnosed as such)
Comment 8 Hans-Peter Nilsson 2006-01-17 02:02:20 UTC
Also seen on 4.1 branch, regression appearing between
Fri Dec 30 21:24:33 UTC 2005 (revision 109181M)
and Wed Jan 11 14:14:27 UTC 2006 (revision 109585M)
for cris-axis-elf, cris-axis-linux-gnu and mmix-knuth-mmixware, cross from
i686-pc-linux-gnu (FC2).
Comment 9 Kazu Hirata 2006-01-23 16:38:11 UTC
Posted a patch.
Comment 10 jules 2006-01-23 17:42:41 UTC
Subject: Bug 25590

Author: jules
Date: Mon Jan 23 17:42:38 2006
New Revision: 110133

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110133
Log:
	Backport from mainline.
	2006-01-23  Kazu Hirata  <kazu@codesourcery.com>
	PR testsuite/25590
	* gcc/testsuite/gcc.dg/tree-ssa/gen-vect-11.c: Add -fwrapv.


Modified:
    branches/csl/sourcerygxx-4_1/ChangeLog.csl
    branches/csl/sourcerygxx-4_1/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-11.c

Comment 11 jules 2006-01-23 17:45:13 UTC
Subject: Bug 25590

Author: jules
Date: Mon Jan 23 17:45:08 2006
New Revision: 110134

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110134
Log:
	Backport from mainline.
	2006-01-23  Kazu Hirata  <kazu@codesourcery.com>
	PR testsuite/25590
	* gcc.dg/tree-ssa/gen-vect-11.c: Add -fwrapv.

Modified:
    branches/csl/coldfire-4_1/ChangeLog.csl
    branches/csl/coldfire-4_1/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-11.c

Comment 12 Kazu Hirata 2006-01-25 16:08:30 UTC
Subject: Bug 25590

Author: kazu
Date: Wed Jan 25 16:08:26 2006
New Revision: 110215

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110215
Log:
	PR testsuite/25590
	* gcc.dg/tree-ssa/gen-vect-11.c: Add -fwrapv.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-11.c

Comment 13 Kazu Hirata 2006-01-25 16:11:23 UTC
Subject: Bug 25590

Author: kazu
Date: Wed Jan 25 16:11:17 2006
New Revision: 110216

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=110216
Log:
	PR testsuite/25590
	* gcc.dg/tree-ssa/gen-vect-11.c: Add -fwrapv.

Modified:
    branches/gcc-4_1-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_1-branch/gcc/testsuite/gcc.dg/tree-ssa/gen-vect-11.c

Comment 14 Kazu Hirata 2006-01-25 16:11:56 UTC
Just checked in a patch.