Bug 22906 - Invalid handling of cache in JarURLConnection
Summary: Invalid handling of cache in JarURLConnection
Status: RESOLVED FIXED
Alias: None
Product: classpath
Classification: Unclassified
Component: classpath (show other bugs)
Version: unspecified
: P3 normal
Target Milestone: 0.19
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-09 17:48 UTC by from-classpath
Modified: 2005-09-20 21:04 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2005-09-11 09:46:30

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description from-classpath 2005-04-09 17:48:50 UTC 
It has been reported that we get that exception on kaffe when executing tomcat5 in some circumstances:

java.lang.IllegalStateException: Zip file already closed: 
/d/local/jakarta-tomcat-5.0.28/common/lib/commons-pool-1.2.jar

Rei Odaira has reported the reason of the bug in the following mail:
http://www.kaffe.org/pipermail/kaffe/2005-April/102100.html

Quickly said, JarURLConnection does not currently check the state of setUseCache and so close wrongly the jar. The attached patch should solve the problem.
Comment 1 Mark Wielaard 2005-09-11 09:46:30 UTC 
Someone on IRC confirmed they do have the same issue.
Comment 2 Tom Tromey 2005-09-20 21:04:33 UTC 
Fix checked in.
Comment 3 cvs-commit@developer.classpath.org 2005-09-20 21:26:51 UTC 
Subject: Bug 22906

CVSROOT:	/cvsroot/classpath
Module name:	classpath
Branch: 	
Changes by:	Tom Tromey <tromey@savannah.gnu.org>	05/09/20 21:01:45

Modified files:
	gnu/java/net/protocol/jar: Connection.java 
	.              : ChangeLog 

Log message:
	PR classpath/22906:
	* gnu/java/net/protocol/jar/Connection.java (get): Added useCaches
	argument.
	(connect): Updated.

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/gnu/java/net/protocol/jar/Connection.java.diff?tr1=1.9&tr2=1.10&r1=text&r2=text
http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.4891&tr2=1.4892&r1=text&r2=text