Bug 22232 - Bug in "fixproto" (missing escape)
Summary: Bug in "fixproto" (missing escape)
Status: RESOLVED FIXED
Alias: None
Product: gcc
Classification: Unclassified
Component: other (show other bugs)
Version: 3.3.6
: P2 normal
Target Milestone: ---
Assignee: Ben Elliston
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-29 14:02 UTC by Anders F Björklund
Modified: 2008-01-24 21:27 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Known to work:
Known to fail:
Last reconfirmed: 2008-01-21 23:25:30


Attachments
gcc-3.3.6-fixproto.patch (238 bytes, patch)
2005-06-29 14:03 UTC, Anders F Björklund
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders F Björklund 2005-06-29 14:02:22 UTC
A bug in the fixproto script makes it get the wrong dir name when:
a) on Darwin, with a different "find" command
b) short directories are present in include dir

This is because a period was not escaped in a sed script within.
i.e. sed -e 's|^./||'`
Suppose to only change ./ beginnings, but wiped my d/ as well...
Comment 1 Anders F Björklund 2005-06-29 14:03:23 UTC
Created attachment 9172 [details]
gcc-3.3.6-fixproto.patch
Comment 2 Ben Elliston 2008-01-23 23:27:08 UTC
Subject: Bug 22232

Author: bje
Date: Wed Jan 23 23:26:24 2008
New Revision: 131768

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131768
Log:
	PR other/22232
	* fixproto: Escape "." in sed expression that strips leading "./".

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/fixproto

Comment 3 Ben Elliston 2008-01-24 00:12:33 UTC
Subject: Bug 22232

Author: bje
Date: Thu Jan 24 00:11:47 2008
New Revision: 131769

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131769
Log:
Revert this patch, as it is not a regression.

2008-01-24  Ben Elliston  <bje@au.ibm.com>

	PR other/22232
	* fixproto: Escape "." in sed expression that strips leading "./".

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/fixproto

Comment 4 Ben Elliston 2008-01-24 20:53:40 UTC
Subject: Bug 22232

Author: bje
Date: Thu Jan 24 20:52:56 2008
New Revision: 131809

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=131809
Log:
Committed with RM approval this time.

	PR other/22232
	* fixproto: Escape "." in sed expression that strips leading "./".

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/fixproto

Comment 5 Ben Elliston 2008-01-24 21:27:45 UTC
Fixed in r131809.