Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug
Bug#: 20389
Product:  
Component:  
Status: RESOLVED
Resolution: FIXED
Assigned To: David Daney <daney@gcc.gnu.org>
Host:
Reported against  
Priority:  
Severity:  
Target Milestone:  
 
 
Target:
Reporter: David Daney <daney@gcc.gnu.org>
Add CC:
CC:
Remove selected CCs
Build:
URL:
Summary:
Keywords:
Known to work:
Known to fail:

Attachment Description Type Created Size Actions
Test2.java Testcase text/plain 2005-03-08 21:16 443 bytes Edit
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 20389 depends on: Show dependency tree
Show dependency graph
Bug 20389 blocks:

Additional Comments:






View Bug Activity   |   Format For Printing   |   Clone This Bug


Description:   Last confirmed: 2005-03-08 21:32 Opened: 2005-03-08 21:09

    

------- Comment #1 From David Daney 2005-03-08 21:13 -------
I will attach a testcase.

I also have a tentative patch and Mauve test that I will submit shortly.

------- Comment #2 From David Daney 2005-03-08 21:16 -------
Created an attachment (id=8367) [edit]
Testcase

As shown in the testcase, a series of marks and reads can cause either
ArrayIndexOutOfBoundsException or erroneous EOF.

------- Comment #3 From Andrew Pinski 2005-03-08 21:23 -------
Confirmed.

------- Comment #4 From David Daney 2005-03-09 00:16 -------
Patch posted here:

http://gcc.gnu.org/ml/java-patches/2005-q1/msg00669.html

------- Comment #5 From CVS Commits 2005-03-09 21:20 -------
Subject: Bug 20389

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	daney@gcc.gnu.org	2005-03-09 21:20:44

Modified files:
	libjava        : ChangeLog 
	libjava/java/io: BufferedInputStream.java InputStreamReader.java 

Log message:
	2005-03-09  David Daney  <ddaney@avtrex.com>
	
	PR libgcj/20389
	Merge BufferedInputStream from GNU Classpath.
	* java/io/BufferedInputStream.java (marktarget): Field removed.
	(CHUNKSIZE): Field removed.
	(bufferSize): New field.
	(BufferedInputStream): Initialize fields.
	(close): Invalidate mark and buffer indexes.
	(mark):  Rewritten.
	(read()): Move mark handling code to refill.
	(read(byte[], int, int)): Ditto.
	(skip): Ditto and simplify EOF testing.
	(refill): Rewritten.
	* java/io/InputStreamReader.java (refill): Removed mark and reset
	of internal BufferedInputStream.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.3391.2.9&r2=1.3391.2.10
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/io/BufferedInputStream.java.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.11&r2=1.11.10.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/io/InputStreamReader.java.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.18&r2=1.18.2.1


------- Comment #6 From CVS Commits 2005-03-09 22:11 -------
Subject: Bug 20389

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	daney@gcc.gnu.org	2005-03-09 22:11:34

Modified files:
	libjava        : ChangeLog 
	libjava/java/io: BufferedInputStream.java InputStreamReader.java 

Log message:
	2005-03-09  David Daney  <ddaney@avtrex.com>
	
	PR libgcj/20389
	Merge BufferedInputStream from GNU Classpath.
	* java/io/BufferedInputStream.java (marktarget): Field removed.
	(CHUNKSIZE): Field removed.
	(bufferSize): New field.
	(BufferedInputStream): Initialize fields.
	(close): Invalidate mark and buffer indexes.
	(mark):  Rewritten.
	(read()): Move mark handling code to refill.
	(read(byte[], int, int)): Ditto.
	(skip): Ditto and simplify EOF testing.
	(refill): Rewritten.
	* java/io/InputStreamReader.java (refill): Removed mark and reset
	of internal BufferedInputStream.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.3406&r2=1.3407
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/io/BufferedInputStream.java.diff?cvsroot=gcc&r1=1.11&r2=1.12
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/io/InputStreamReader.java.diff?cvsroot=gcc&r1=1.18&r2=1.19


------- Comment #7 From Andrew Pinski 2005-03-09 22:44 -------
Fixed.

Bug List: (This bug is not in your last search results)   Show last search results      Search page      Enter new bug