• GCC_Patch_Tracking

Patch tracking systems

GCC does not use a patch tracker at the moment. Submitters are expected to track their own unreviewed patches and ping maintainers for reviews.

Past proposals for patch tracking systems (see below) have failed to gather any acceptance due to the perceived overhead imposed on reviewers for manually managing and updating patch status and queues.

The remainder of this page is deprecated.

Diego Novillo has set up a Rietveld repository for tracking GCC patches. Instructions and details at http://gcc.gnu.org/wiki/rietveld.

What other systems could be used?

• http://source.winehq.org/patches/ Perhaps too simple.

• https://patchwork.kernel.org/project/LKML/list/ It would require categories.

• http://demo.reviewboard.org/r/ Too much

GCC Patch Queue

(The patch queue is inoperative at the moment. GCC developers would love to have a similar system installed in the gcc.gnu.org server but no one has come forward so far to set it up, so any help on this would be appreciated.)

Daniel Berlin has set up a simple patch queue for tracking patches.

This document should follow the instructions given by Daniel.

The tracker is quite simple for now, and just lists the patches along with a submit date and archive url, and color codes the dates by how long they have been outstanding.

More may come later (pinging, whatever)

Adding Patches

If you want a patch tracked, please have a line in your email to gcc-patches that consists of solely

:ADDPATCH <maintenance area>:

It ignores other lines, so you can put this at the top, the middle, or wherever. It just has to be somewhere in the email on a line by itself. For example:

This is patch blah blah blah
:ADDPATCH SSA:

Thanks,
Dan

or

:ADDPATCH SSA:

This is patch blah blah blah

Thanks,
Dan

but the following will not work

This is patch blah blah blah :ADDPATCH SSA:

Thanks,
Dan

It should show up in the patch tracker soon afterwards.

You can also add a patch to the tracker manually using the add link at the bottom of the tracker. Patches added manually must be removed manually too

Reviewing Patches

If you review a patch by replying from your mailer, simply reply to the email that had the ADDPATCH line in it, and include a line:

:REVIEWMAIL:

It will figure out which patch you were reviewing (by the in-reply-to column) and remove it from the queue list.

If you are replying to something out of the archives, please put

:REVIEWURL <mailing list archive url>:

If you are just randomly reviewing patches you found on the tracker, and are too lazy to post the url, simply include:

:REVIEWID <patch id>:

and it will mark the patch as reviewed.

You can also manually remove patches through the remove link. I may disable this feature if it is abused (or restrict it's access).