[PATCH v11] libstdc++: container heterogeneous insertion (P2363) [PR117402]

[Nathan Myers]

On 3/3/26 10:55 AM, Jonathan Wakely wrote:
> On Fri, 27 Feb 2026 at 21:58 -0500, Nathan Myers wrote:
>> Changes in v11
>>  - Delete #include, debug instrumentation that called abort.
>>  - Delete spurious DR comment text.
>>  - Delete unused _M_index_to_tr.
>>  - Un-de-duplicate lower/upper_bound apparatus, pending cleanup
>>   in gcc-17.
>>  - Regularize formal argument names (e.g. __pos -> __hint) for
>>   consistency and to match doxygen annotations.
>>  - Move ++after, --before iterator operations to separate
>>   statement for better clarity.
>>  - Improve tests.
>>  - Further improve, regularize doxygen annotation text.
>>  - Adjust Changelog entries to match.
...
>> @@ -383,45 +378,39 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER
>>       { return allocator_type(_M_t.get_allocator()); }
>>
>>       // iterators
>> +      ///@{
>>       /**
>> -       *  Returns a read/write iterator that points to the first pair 
>> in the
>> -       *  %map.
>> +       *  Returns a read/write iterator to the first pair element in the
>> +       *  %map, or end() if no such element exists.
> 
> Why are you doing all these doxygen changes in the same patch as the
> heterogeneous insertions?!
> The might be fine changes but they don't belong in this patch.
> (And have you checked that the grouping with ///@{ actually works as
> intended here? It doesn't always!)

Fixed in v12.