[PATCH] libstdc++: Add comment justifying separate proxy_random_access_iterator_wrapper.
Jonathan Wakely
jwakely@redhat.com
Wed Jan 14 10:21:28 GMT 2026
On Wed, 14 Jan 2026 at 09:40, Tomasz Kamiński <tkaminsk@redhat.com> wrote:
>
> It meets Cpp17RandomAccessIterator requirements, but does not satisfy
> random_access_iterator concept.
>
> libstdc++-v3/ChangeLog:
>
> * testsuite/util/testsuite_iterators.h: Modify comment.
> ---
> Giving oportunity to check for typos and grammar issues.
> OK for trunk?
OK, thanks
>
> libstdc++-v3/testsuite/util/testsuite_iterators.h | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/libstdc++-v3/testsuite/util/testsuite_iterators.h b/libstdc++-v3/testsuite/util/testsuite_iterators.h
> index caede49e41b..ca022e5d0f9 100644
> --- a/libstdc++-v3/testsuite/util/testsuite_iterators.h
> +++ b/libstdc++-v3/testsuite/util/testsuite_iterators.h
> @@ -695,9 +695,12 @@ namespace __gnu_test
> * @brief random_access_iterator wrapper for pointer,
> * that returns proxy from subscript.
> *
> - * This class takes a pointer and wraps it to provide exactly
> - * the requirements of a random_access_iterator. It should not be
> - * instantiated directly, but generated from a test_container
> + * This is separate from random_access_iterator_wrapper (that returns
> + * T& from operator subscript), as it meets the requirements of
> + * Cpp17RandomAccessIterator (C++20 [tab:randomaccessiterator])
> + * that allows to return type that is convertible to reference,
> + * but does not satisfy random_access_iterator concept
> + * (C++20 [random_access_iterator]).
> */
> template<class T>
> struct proxy_random_access_iterator_wrapper
> --
> 2.52.0
>
More information about the Libstdc++
mailing list