[PATCH] libstdc++: Check right value of __cpp_lib_format for dynamic_string

[Jonathan Wakely]

On Thu, 2 Apr 2026, 00:08 Tim Song, <t.canens.cpp@gmail.com> wrote:

> But s/dynamic_string/dynamic_format/g, right?
>

Ah yes! Thanks, I'll change it before I push.



> On Wed, Apr 1, 2026 at 4:10 PM Tomasz Kaminski <tkaminsk@redhat.com>
> wrote:
>
>>
>>
>> On Wed, Apr 1, 2026 at 10:40 PM Jonathan Wakely <jwakely@redhat.com>
>> wrote:
>>
>>> This doesn't matter in practice, but strictly speaking the right value
>>> for defining std::dynamic_string is 202603 not 202311 (which was the
>>> macro value for the old name, std::runtime_format).
>>>
>>> libstdc++-v3/ChangeLog:
>>>
>>>         * include/std/format (dynamic_string): Check new value for
>>>         feature test macro.
>>> ---
>>>
>>> Tested x86_64-linux.
>>>
>> Makes sense.
>>
>>>
>>>  libstdc++-v3/include/std/format | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libstdc++-v3/include/std/format
>>> b/libstdc++-v3/include/std/format
>>> index 2bcd06822b75..eca5bd213aa0 100644
>>> --- a/libstdc++-v3/include/std/format
>>> +++ b/libstdc++-v3/include/std/format
>>> @@ -195,7 +195,7 @@ namespace __format
>>>        = basic_format_string<wchar_t, type_identity_t<_Args>...>;
>>>  #endif
>>>
>>> -#if __cpp_lib_format >= 202311L // >= C++26
>>> +#if __cpp_lib_format >= 202603L // >= C++26
>>>    [[__gnu__::__always_inline__]]
>>>    inline __format::_Dynamic_format_string<char>
>>>    dynamic_format(string_view __fmt) noexcept
>>> --
>>> 2.53.0
>>>
>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://gcc.gnu.org/pipermail/libstdc++/attachments/20260402/61b44bb8/attachment-0001.htm>