[PATCH v3 0/4] libstdc++: Implement padded layouts.

[Tomasz Kaminski]

On Thu, Sep 25, 2025 at 1:32 PM Luc Grosheintz <luc.grosheintz@gmail.com>
wrote:

>
>
> On 9/25/25 1:27 PM, Tomasz Kaminski wrote:
> > Hi,
> >
> > I have reviewed all the patches, and the comments are mostly style, and
> > few organizational, but there are a bunch of them. I may also take
> another
> > quick look on
> > constraints tomorrow, to see if I missed anything, so you may wait with
> > posting if you
> > prefer avoiding another revision.
>
> Thank you, I've started reading through them. I'll start making
> all changes locally; but wait with posting v4. Please let me know
> when you consider the review round completed.
>
Second pass of review is done, so post v4 when you will be ready.


> >
> > Regards,
> > Tomasz
> >
> > On Tue, Sep 23, 2025 at 3:32 PM Luc Grosheintz <luc.grosheintz@gmail.com
> >
> > wrote:
> >
> >> Changes since v2:
> >>
> >>    - Refactored/rewrote the implementation of layout_left_padded.
> >>    - Added implementation of layout_right_padded.
> >>    - Implemented the review comments.
> >>
> >> Luc Grosheintz (4):
> >>    libstdc++: Prepare mapping layout tests for padded layouts.
> >>    libstdc++: Refactor __mdspan::__static_quotient.
> >>    libstdc++: Implement std::layout_left_padded.
> >>    libstdc++: Implement layout_right_padded.
> >>
> >>   libstdc++-v3/include/bits/version.def         |  10 +
> >>   libstdc++-v3/include/bits/version.h           |   9 +
> >>   libstdc++-v3/include/std/mdspan               | 947 +++++++++++++++++-
> >>   libstdc++-v3/src/c++23/std.cc.in              |   9 +-
> >>   .../mdspan/layouts/class_mandate_neg.cc       |   1 +
> >>   .../23_containers/mdspan/layouts/ctors.cc     |  70 +-
> >>   .../23_containers/mdspan/layouts/empty.cc     | 161 +--
> >>   .../23_containers/mdspan/layouts/mapping.cc   | 242 ++++-
> >>   .../23_containers/mdspan/layouts/padded.cc    | 679 +++++++++++++
> >>   .../mdspan/layouts/padded_neg.cc              | 352 +++++++
> >>   .../mdspan/layouts/padded_traits.h            | 192 ++++
> >>   11 files changed, 2535 insertions(+), 137 deletions(-)
> >>   create mode 100644
> >> libstdc++-v3/testsuite/23_containers/mdspan/layouts/padded.cc
> >>   create mode 100644
> >> libstdc++-v3/testsuite/23_containers/mdspan/layouts/padded_neg.cc
> >>   create mode 100644
> >> libstdc++-v3/testsuite/23_containers/mdspan/layouts/padded_traits.h
> >>
> >> --
> >> 2.50.1
> >>
> >>
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://gcc.gnu.org/pipermail/libstdc++/attachments/20250926/28d8f9e5/attachment.htm>