[PATCH 1/5] libstdc++: keep subtree sizes in pb_ds binary search trees (PR 81806)

[Jonathan Wakely]

On 13/07/20 16:40 +0800, Xi Ruoyao via Libstdc++ wrote:
>> The first patch removes two redundant statements which are confusing.  It
>> should
>> be applied anyway, disregarding other patches.
>
>The patch is attached, to prevent my mail client from destroying it :(.
>
>Please ignore a previous duplication of this mail with wrong title :(.
>
>libstdc++-v3/ChangeLog:
>
>	* include/ext/pb_ds/detail/bin_search_tree_/insert_fn_imps.hpp
>	  (insert_leaf_new, insert_imp_empty): remove redundant statements.
>-- 
>Xi Ruoyao <xry111@mengyan1223.wang>
>School of Aerospace Science and Technology, Xidian University

>From 4eea45261ebf974ddf02f6154166c5cb6aa180da Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?X=E2=84=B9=20Ruoyao?= <xry111@mengyan1223.wang>
>Date: Fri, 10 Jul 2020 20:10:52 +0800
>Subject: [PATCH 1/5] libstdc++: remove two redundant statements in pb_ds
> binary tree
>
>libstdc++-v3/ChangeLog:
>
>	* include/ext/pb_ds/detail/bin_search_tree_/insert_fn_imps.hpp
>	  (insert_leaf_new, insert_imp_empty): remove redundant statements.

OK for trunk.

>---
> .../ext/pb_ds/detail/bin_search_tree_/insert_fn_imps.hpp        | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/libstdc++-v3/include/ext/pb_ds/detail/bin_search_tree_/insert_fn_imps.hpp b/libstdc++-v3/include/ext/pb_ds/detail/bin_search_tree_/insert_fn_imps.hpp
>index 3942da05600..bdc10379af6 100644
>--- a/libstdc++-v3/include/ext/pb_ds/detail/bin_search_tree_/insert_fn_imps.hpp
>+++ b/libstdc++-v3/include/ext/pb_ds/detail/bin_search_tree_/insert_fn_imps.hpp
>@@ -122,7 +122,6 @@ insert_leaf_new(const_reference r_value, node_pointer p_nd, bool left_nd)
>     }
> 
>   p_new_nd->m_p_parent = p_nd;
>-  p_new_nd->m_p_left = p_new_nd->m_p_right = 0;
>   PB_DS_ASSERT_NODE_CONSISTENT(p_nd)
> 
>   update_to_top(p_new_nd, (node_update* )this);
>@@ -142,7 +141,6 @@ insert_imp_empty(const_reference r_value)
>     m_p_head->m_p_parent = p_new_node;
> 
>   p_new_node->m_p_parent = m_p_head;
>-  p_new_node->m_p_left = p_new_node->m_p_right = 0;
>   _GLIBCXX_DEBUG_ONLY(debug_base::insert_new(PB_DS_V2F(r_value));)
> 
>   update_to_top(m_p_head->m_p_parent, (node_update*)this);
>-- 
>2.27.0
>