[PATCH 3/4] libstdc++: Avoid '-Wunused-parameter' for 'is_directory' in member function 'bool std::filesystem::__cxx11::_Dir::do_unlink(bool, std::error_code&) const'

[Jonathan Wakely]

On Thu, 20 Feb 2025 at 17:02, Thomas Schwinge <tschwinge@baylibre.com> wrote:
>
> In a newlib configuration:
>
>     ../../../../../source-gcc/libstdc++-v3/src/c++17/fs_dir.cc: In member function ‘bool std::filesystem::__cxx11::_Dir::do_unlink(bool, std::error_code&) const’:
>     ../../../../../source-gcc/libstdc++-v3/src/c++17/fs_dir.cc:147:18: error: unused parameter ‘is_directory’ [-Werror=unused-parameter]
>       147 |   do_unlink(bool is_directory, error_code& ec) const noexcept
>           |             ~~~~~^~~~~~~~~~~~
>
>         libstdc++-v3/
>         * src/c++17/fs_dir.cc (do_unlink): Tag 'is_directory' as
>         '[[maybe_unused]]'.

OK


> ---
>  libstdc++-v3/src/c++17/fs_dir.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/src/c++17/fs_dir.cc b/libstdc++-v3/src/c++17/fs_dir.cc
> index cd75e0541d3..9347a8a46dc 100644
> --- a/libstdc++-v3/src/c++17/fs_dir.cc
> +++ b/libstdc++-v3/src/c++17/fs_dir.cc
> @@ -144,7 +144,7 @@ struct fs::_Dir : _Dir_base
>    }
>
>    bool
> -  do_unlink(bool is_directory, error_code& ec) const noexcept
> +  do_unlink([[maybe_unused]] bool is_directory, error_code& ec) const noexcept
>    {
>  #if _GLIBCXX_HAVE_UNLINKAT
>      const auto atp = current();
> --
> 2.34.1
>