[PATCH 1/3] libstdc++: Implement std::philox_engine for targets without __int128
Jonathan Wakely
jwakely.gcc@gmail.com
Wed Dec 17 20:25:41 GMT 2025
On Wed, 17 Dec 2025 at 20:22, Jakub Jelinek wrote:
>
> On Wed, Dec 17, 2025 at 07:50:15PM +0000, Jonathan Wakely wrote:
> > + __rand_uint128(const __rand_uint128&) = default;
> > + __rand_uint128& operator=(const __rand_uint128&) = default;
>
> You could use type instead of __rand_uint128 in these arguments too.
Indeed. I used it elsewhere because it's a bit less ugly and easier to
read. For the constructor it would need to be:
__rand_uint128(const type&) = default;
and I thought that was less clear than just repeating the real class name.
And for the defaulted assignment, it also seemed clearer to define
them using the real class name.
>
> Otherwise LGTM, but what do I know about C++ ;)
Enough to make this fix possible :)
Thanks for the reviews.
More information about the Libstdc++
mailing list