GCN, nvptx libstdc++: Force use of '__atomic' builtins [PR119645]

[Andrew Stubbs]

On 07/04/2025 09:07, Thomas Schwinge wrote:
> Hi!
> 
> On 2025-03-14T11:39:20+0100, I wrote:
>> As the first of a few patches to enable libstdc++ for GCN, nvptx targets,
>> [...]
> 
>> some more fine-tuning is to follow later on.)
> 
> Any comments before I push the attached
> "GCN, nvptx libstdc++: Force use of '__atomic' builtins [PR119645]"?
> 
> Jonathan, please put a sharp eye on the
> 'libstdc++-v3/acinclude.m4:GLIBCXX_ENABLE_LOCK_POLICY' change; to make
> sure this only affects GCN, nvptx, but nothing else.
> 
> 
> Grüße
>   Thomas
> 
> 


> +  amdgcn-*-amdhsa)
> +    # To avoid greater pain elsewhere, force use of '__atomic' builtins,
> +    # irregardless of outcome of 'configure' checks; see PR119645
> +    # "GCN, nvptx: libstdc++ 'checking for atomic builtins [...]... no'".
> +    atomicity_dir=cpu/generic/atomicity_builtins
> +    ;;

"irregardless" is not a good word. Just use "regardless" (of the 
outcome) or "disregarding" (the outcome).

Otherwise LGTM. At least GCN certainly does support atomics, so the 
configure test must be broken somehow.

Andrew