[PATCH 01/10] libstdc++: Remove unnecessary 'static' from __is_specialization_of

Jonathan Wakely jwakely.gcc@gmail.com
Tue Sep 24 06:45:02 GMT 2024


On Tue, 24 Sept 2024, 00:44 Nathaniel Shead, <nathanieloshead@gmail.com>
wrote:

> Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk?
>

OK, thanks


> -- >8 --
>
> This makes the declarations internal linkage, which is an ODR issue, and
> causes a future modules patch to fail regtest as it now detects attempted
> uses of TU-local entities in module CMIs.
>
> libstdc++-v3/ChangeLog:
>
>         * include/std/format: Remove unnecessary 'static'.
>
> Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>
> ---
>  libstdc++-v3/include/std/format | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/libstdc++-v3/include/std/format
> b/libstdc++-v3/include/std/format
> index e963d7f79b3..d9014d111b1 100644
> --- a/libstdc++-v3/include/std/format
> +++ b/libstdc++-v3/include/std/format
> @@ -361,10 +361,9 @@ namespace __format
>
>  /// @cond undocumented
>    template<typename _Tp, template<typename...> class _Class>
> -    static constexpr bool __is_specialization_of = false;
> +    constexpr bool __is_specialization_of = false;
>    template<template<typename...> class _Class, typename... _Args>
> -    static constexpr bool __is_specialization_of<_Class<_Args...>, _Class>
> -      = true;
> +    constexpr bool __is_specialization_of<_Class<_Args...>, _Class> =
> true;
>
>  namespace __format
>  {
> --
> 2.46.0
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://gcc.gnu.org/pipermail/libstdc++/attachments/20240924/3d10ddc8/attachment.htm>


More information about the Libstdc++ mailing list