[PATCH][risc-v] libstdc++: Preserve signbit of nan when converting float to double [PR113578]

Jonathan Wakely jwakely.gcc@gmail.com
Tue May 7 16:39:30 GMT 2024


On Tue, 7 May 2024 at 17:33, Jeff Law wrote:
>
>
>
> On 5/7/24 9:36 AM, Andreas Schwab wrote:
> > On Mai 07 2024, Jonathan Wakely wrote:
> >
> >> +#ifdef __riscv
> >> +    return _M_insert(__builtin_copysign((double)__f,
> >> +                                        (double)-__builtin_signbit(__f));
> >
> > Should this use static_cast<double>?

Meh. It wouldn't fit in 80 columns any more with static_cast, and it
means exactly the same thing.

> And it's missing a close paren.

Now that's more important! Thanks.


More information about the Libstdc++ mailing list