[committed, v4] libstdc++: Handle encodings in localized chrono formatting [PR109162]

[Jonathan Wakely]

On Wed, 31 Jul 2024 at 19:17, Dimitar Dimitrov <dimitar@dinux.eu> wrote:
>
> On Wed, Jul 31, 2024 at 05:09:52PM +0100, Jonathan Wakely wrote:
> > It took a while, but I was finally happy with this v4 patch, so I pushed
> > it to trunk. Then I noticed silly mistake in the new test, which I'll
> > fix shortly.
> >
> ...
> > +#if defined _GLIBCXX_HAVE_ICONV
> > +  ::iconv_t _M_cd = (::iconv_t)-1;
> > +  mutable mutex mx;
> > +#endif
>
> Hi Jonathan,
>
> This patch caused pru-unknown-elf build to break:
>   /mnt/nvme/dinux/local-workspace/gcc/libstdc++-v3/src/c++20/format.cc:86:11: error: ‘mutex’ does not name a type
>      86 |   mutable mutex mx;
>         |           ^~~~~
>
> Should the section also be guarded by _GLIBCXX_HAS_GTHREADS ?

Doh, yes it should. I'll fix that today.