[PATCH] libstdc++: drop bogus 'dg_do run' directive
Sam James
sam@gentoo.org
Wed Jul 31 16:21:40 GMT 2024
Jonathan Wakely <jwakely@redhat.com> writes:
> On Wed, 31 Jul 2024 at 16:45, Sam James <sam@gentoo.org> wrote:
>>
>> We already have a valid 'dg-do run' (- vs _) directive, so drop the bogus
>> one.
>>
>> libstdc++-v3/ChangeLog:
>> * testsuite/28_regex/traits/char/translate.cc: Drop bogus 'dg_do run'.
>> ---
>> OK? No regressions in the logs but it's a bit weird that it's got a proper
>> directive with a target specifier so I thought I'd check rather than doing
>> it as obvious.
>
> Definitely OK. Dejagnu will ignore it because it doesn't start with
> dg- so it is useless.
Thank you! Will push shortly.
>
> Even if it was used, it would be wrong because std::regex can't be
> used in C++98 so the c++11 effective target is needed.
That's the missing piece I was looking for -- I just didn't want to be
dropping the bogus directive and covering up if something else was wrong
there.
> [...]
thanks,
sam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 377 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/libstdc++/attachments/20240731/32f9a1bc/attachment.sig>
More information about the Libstdc++
mailing list