[PATCH] libstdc++: Fix testsuite with -Wformat

[Jonathan Wakely]

On 06/12/23 15:34 +0100, Gwenole Beauchesne wrote:
>Tested on x86_64-pc-linux-gnu with --enable-languages=c,c++ and
>additional -Wformat to CXXFLAGS.

Please CC the libstdc++@gcc.gnu.org list on all libstdc++ patches, as
documented at https://gcc.gnu.org/lists.html

Otherwise I won't see the patches unless I happen to glance at the
gcc-patches archive by chance.

The patch seems OK, but what exactly is it fixing? I don't see any
warning when adding -Wformat to the test flags.

>-- >8 --
>
>Fix testsuite when compiling with -Wformat. Use nonnull arguments so
>that -Wformat does not cause extraneous output to be reported as an
>error.
>
>FAIL: tr1/8_c_compatibility/cinttypes/functions.cc (test for excess errors)
>
>libstdc++-v3/ChangeLog:
>
>    * testsuite/tr1/8_c_compatibility/cinttypes/functions.cc: Use
>    nonnull arguments to strtoimax() and wcstoimax() functions.
>
>Signed-off-by: Gwenole Beauchesne <gb.devel@gmail.com>
>---
> .../testsuite/tr1/8_c_compatibility/cinttypes/functions.cc    | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/libstdc++-v3/testsuite/tr1/8_c_compatibility/cinttypes/functions.cc b/libstdc++-v3/testsuite/tr1/8_c_compatibility/cinttypes/functions.cc
>index 518ddf49875..21f5263b5cc 100644
>--- a/libstdc++-v3/testsuite/tr1/8_c_compatibility/cinttypes/functions.cc
>+++ b/libstdc++-v3/testsuite/tr1/8_c_compatibility/cinttypes/functions.cc
>@@ -29,10 +29,10 @@ void test01()
> #if _GLIBCXX_USE_C99_INTTYPES_TR1
>
>   std::tr1::intmax_t i = 0, numer = 0, denom = 0, base = 0;
>-  const char* s = 0;
>+  const char* s = "0";
>   char** endptr = 0;
> #if defined(_GLIBCXX_USE_WCHAR_T) && _GLIBCXX_USE_C99_INTTYPES_WCHAR_T_TR1
>-  const wchar_t* ws = 0;
>+  const wchar_t* ws = L"0";
>   wchar_t** wendptr = 0;
> #endif
>