Patch: Remove unneeded double operation in libstdc++-v3/src/c++17/fs_path.cc
Martin Küttler
martin.kuettler@kernkonzept.com
Fri Jan 5 12:45:18 GMT 2024
>>This is a small change to libstdc++ which does not change any behavior.
>
> Please CC the libstdc++@gcc.gnu.org list on all libstdc++ patches, as
> documented at https://gcc.gnu.org/lists.html
Acknowledged. Sorry.
>>This change has two, ihmo positive, implications:
>>
>> - The implicit conversion from double to int is avoided (Avoiding a
>> warning).
>
> I don't see any warning here. What do you see?
I see "warning: conversion from ‘double’ to ‘int’ may change value
[-Wfloat-conversion]" This appears to be a specifically enabled warning.
> Looking at path::_List::reserve now, we probably also want to avoid
> overflow. Although a path with INT_MAX/1.5 components seems
> implausible for 32-bit and 64-bit targets, it could be a problem for
> 16-bit targets. I'll take care of that too.
Nice catch.
Martin
--
Kernkonzept GmbH at Dresden, Germany, HRB 31129, CEO Dr.-Ing. Michael Hohmuth
More information about the Libstdc++
mailing list