[PATCH] libstdc++: Correct NTTP and simd_mask ctor call
Alexandre Oliva
oliva@adacore.com
Fri Jun 2 09:30:17 GMT 2023
On Jun 2, 2023, Matthias Kretz <m.kretz@gsi.de> wrote:
> I'm looking at that function again, also in light of recent improvements wrt.
> code-gen, and will remove that assumption, that long long is vectorizable.
Thanks, I'll leave that to you, then.
I also noticed the same test is failing on rtems6 (at least with gcc
11). AFAICT the problem is that _GLIBCXX_SIMD_MATH_CALL* macros in
simd_math.h expect the named functions to be in std::, but I get such
errors as:
.../aarch64-rtems6/include/c++/11.4.1/experimental/bits/simd_math.h:1299: error: 'remainder' is not a member of 'std'
.../aarch64-rtems6/include/c++/11.4.1/experimental/bits/simd_math.h:1299: note: suggested alternatives:
[...]
.../aarch64-rtems6/include/math.h:346: note: 'remainder'
[...]
.../aarch64-rtems6/include/c++/11.4.1/experimental/bits/simd_math.h:1299: note: 'std::experimental::parallelism_v2::remainder'
.../aarch64-rtems6/include/c++/11.4.1/experimental/bits/simd_math.h:1299: error: template argument 1 is invalid
[...]
.../aarch64-rtems6/include/c++/11.4.1/experimental/bits/simd_math.h:1328: error: 'fmin' is not a member of 'std'; did you mean 'min'?
.../aarch64-rtems6/include/c++/11.4.1/experimental/bits/simd_math.h:1328: error: 'fmin' is not a member of 'std'; did you mean 'min'?
.../aarch64-rtems6/include/c++/11.4.1/experimental/bits/simd_math.h:1328: error: template argument 1 is invalid
ISTM that rtems is missing some of the math.h functions expected by
libstdc++, but also that even those that are present are not visible in
namespace ::std::, where the macros reasonably expect to find them. Is
this known? Should I file a PR about it?
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
More information about the Libstdc++
mailing list