[PATCH] libstdc++ testsuite/std/ranges/iota/max_size_type.cc: Reduce /10 for simulators
Hans-Peter Nilsson
hp@bitrange.com
Sun Dec 31 16:56:02 GMT 2023
On Sat, 30 Dec 2023, Hans-Peter Nilsson wrote:
> On Sat, 30 Dec 2023, Jonathan Wakely wrote:
>
> > On Sat, 30 Dec 2023, 01:41 Hans-Peter Nilsson, <hp@bitrange.com> wrote:
> > > Or perhaps the cause is known?
> >
> > Not to me. It probably is a target codegen bug, since all this test really
> > does is emulate a wide integer type using masks and shifts.
>
> If so, a generic code-generator bug. I've repeated the 5x
> performance regression observation for a native build and
> updated PR113175 (.32 vs 1.73 seconds). I'll see if I can
> quickly find out whether it's codegen or libstdc++. I set it
> the PR to the latter for the moment.
Now changed to /testsuite, because the apparent cause for the
magnitude increase (.32 -> 1.63 seconds) is the testsuite part
of r14-205. See the PR for details.
HNY!
>
> > > With this, the test successfully completes in ~34 seconds.
> > >
> > > Ok to commit?
> > >
> >
> > Looks OK to me, but Patrick wrote this test so please wait for him to
> > confirm. I think this just reduces the number of cases tested, but doesn't
> > miss any important edge cases that should be checked.
>
> Understood: holding, but will ping after the usual week.
> Thanks for the review!
>
> brgds, H-P
>
More information about the Libstdc++
mailing list