[PATCH 13/16] Improve test codegen for interpreting assembly

Jonathan Wakely jwakely@redhat.com
Tue Feb 2 15:02:23 GMT 2021


On 27/01/21 21:42 +0100, Matthias Kretz wrote:
>From: Matthias Kretz <kretz@kde.org>
>
>In many failure cases it is helpful to inspect the instructions leading
>up to the test failure. After this change the location is easier to find
>and the branch after failure is easier to find.
>
>libstdc++-v3/ChangeLog:
>	* testsuite/experimental/simd/tests/bits/verify.h (verify): Add
>	instruction pointer data member. Ensure that the `if (m_failed)`
>	branch is always inlined into the calling code. The body of the
>	conditional can still be a function call. Move the get_ip call
>	into the verify ctor to simplify the ctor calls.
>	(COMPARE): Don't mention the use of all_of for reduction of a
>	simd_mask. It only distracts from the real issue.
>---
> .../experimental/simd/tests/bits/verify.h     | 44 +++++++++----------
> 1 file changed, 22 insertions(+), 22 deletions(-)
>
>diff --git a/libstdc++-v3/testsuite/experimental/simd/tests/bits/verify.h b/
>libstdc++-v3/testsuite/experimental/simd/tests/bits/verify.h

Several of these patches have been mangled by your mailer. The line
above has been wrapped in the middle of the filename, making this an
invalid patch header.

>@@ -220,24 +223,21 @@ template <typename T>
>
> #define COMPARE(_a, _b)
>\

And all these lines ending with a backslash have been wrapped.

I can easily fix the filename in the header, but my simplistic
attempts to put this back together have failed. Could you please
resend patch 13/16 as an attachment, not inline?

I think the others are OK.




More information about the Libstdc++ mailing list