[PATCH] Define _C99 in libstdc++ vxworks/os_defines.h

Olivier Hainque hainque@adacore.com
Fri Dec 10 16:15:51 GMT 2021



> On 10 Dec 2021, at 16:42, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
> 
> 
> OK to commit then, thanks.
> 
> The comment is a bit misleading though:
> 
> +// libstdc++ relies on C99 features for virtually all versions of C++,
> +// up to at least C++98.
> +#undef _C99
> +#define _C99 1
> 
> The "up to" seems backwards, I'd expect it to say "down to" or "as far
> back as at least C++98".
> 
> But there's nothing older than C++98 anyway, so this just means "all
> versions", there's no "virtually" about it.
> 
> Please just say "libstdc++ relies on C99 features for all versions of C++".

Sure, thanks Jonathan. Yes, I agree the comment is confused.
I hesitated between a couple of perspectives and just mixed
things up.

Thanks for your prompt review!

Olivier


More information about the Libstdc++ mailing list