First time contributor, adding p1004 for C++20 -- constexpr std::vector
Josh Marshall
joshua.r.marshall.1991@gmail.com
Thu Jul 30 17:37:55 GMT 2020
Which branch should I be branching off of to develop from? Master
looks like it is having compile failures:
```
Making all in c++17
make[6]: Entering directory
'/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/src/c++17'
/bin/bash ../../libtool --tag CXX --tag disable-shared
--mode=compile /home/anadon/Documents/code/gcc/host-x86_64-pc-linux-gnu/gcc/xgcc
-shared-libgcc -B/home/anadon/Documents/code/gcc/host-x86_64-pc-linux-gnu/gcc
-nostdinc++ -L/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/src
-L/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/src/.libs
-L/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/libsupc++/.libs
-B/usr/local/x86_64-pc-linux-gnu/bin/
-B/usr/local/x86_64-pc-linux-gnu/lib/ -isystem
/usr/local/x86_64-pc-linux-gnu/include -isystem
/usr/local/x86_64-pc-linux-gnu/sys-include -fno-checking
-I/home/anadon/Documents/code/gcc/libstdc++-v3/../libgcc
-I/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/include/x86_64-pc-linux-gnu
-I/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/include
-I/home/anadon/Documents/code/gcc/libstdc++-v3/libsupc++
-std=gnu++17 -prefer-pic -D_GLIBCXX_SHARED -fno-implicit-templates
-Wall -Wextra -Wwrite-strings -Wcast-qual -Wabi=2
-fdiagnostics-show-location=once -ffunction-sections -fdata-sections
-frandom-seed=floating_from_chars.lo -fimplicit-templates -g -O2
-D_GNU_SOURCE -fcf-protection -mshstk -c -o floating_from_chars.lo
../../../.././libstdc++-v3/src/c++17/floating_from_chars.cc
libtool: compile:
/home/anadon/Documents/code/gcc/host-x86_64-pc-linux-gnu/gcc/xgcc
-shared-libgcc -B/home/anadon/Documents/code/gcc/host-x86_64-pc-linux-gnu/gcc
-nostdinc++ -L/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/src
-L/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/src/.libs
-L/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/libsupc++/.libs
-B/usr/local/x86_64-pc-linux-gnu/bin/
-B/usr/local/x86_64-pc-linux-gnu/lib/ -isystem
/usr/local/x86_64-pc-linux-gnu/include -isystem
/usr/local/x86_64-pc-linux-gnu/sys-include -fno-checking
-I/home/anadon/Documents/code/gcc/libstdc++-v3/../libgcc
-I/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/include/x86_64-pc-linux-gnu
-I/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/include
-I/home/anadon/Documents/code/gcc/libstdc++-v3/libsupc++ -std=gnu++17
-D_GLIBCXX_SHARED -fno-implicit-templates -Wall -Wextra
-Wwrite-strings -Wcast-qual -Wabi=2 -fdiagnostics-show-location=once
-ffunction-sections -fdata-sections
-frandom-seed=floating_from_chars.lo -fimplicit-templates -g -O2
-D_GNU_SOURCE -fcf-protection -mshstk -c
../../../.././libstdc++-v3/src/c++17/floating_from_chars.cc -fPIC
-DPIC -D_GLIBCXX_SHARED -o floating_from_chars.o
../../../.././libstdc++-v3/src/c++17/floating_from_chars.cc: In
function ‘std::ptrdiff_t std::{anonymous}::from_chars_impl(const
char*, T&, std::errc&)’:
../../../.././libstdc++-v3/src/c++17/floating_from_chars.cc:304:25:
error: ‘strtof’ is not a member of ‘std’; did you mean ‘strtof’?
304 | tmpval = std::strtof(str, &endptr);
| ^~~~~~
In file included from
/gnu/store/jf722ghbjc4gcmafcf7ics478jx7vv4j-profile/include/c++/stdlib.h:30,
from
/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/include/cstdlib:75,
from
/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/include/ext/string_conversions.h:41,
from
/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/basic_string.h:6535,
from
/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/include/string:55,
from
../../../.././libstdc++-v3/src/c++17/floating_from_chars.cc:31:
/gnu/store/jf722ghbjc4gcmafcf7ics478jx7vv4j-profile/include/stdlib.h:123:14:
note: ‘strtof’ declared here
123 | extern float strtof (const char *__restrict __nptr,
| ^~~~~~
../../../.././libstdc++-v3/src/c++17/floating_from_chars.cc:308:25:
error: ‘strtold’ is not a member of ‘std’; did you mean ‘strtold’?
308 | tmpval = std::strtold(str, &endptr);
| ^~~~~~~
In file included from
/gnu/store/jf722ghbjc4gcmafcf7ics478jx7vv4j-profile/include/c++/stdlib.h:30,
from
/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/include/cstdlib:75,
from
/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/include/ext/string_conversions.h:41,
from
/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/basic_string.h:6535,
from
/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/include/string:55,
from
../../../.././libstdc++-v3/src/c++17/floating_from_chars.cc:31:
/gnu/store/jf722ghbjc4gcmafcf7ics478jx7vv4j-profile/include/stdlib.h:126:20:
note: ‘strtold’ declared here
126 | extern long double strtold (const char *__restrict __nptr,
| ^~~~~~~
In file included from
/gnu/store/jf722ghbjc4gcmafcf7ics478jx7vv4j-profile/include/c++/math.h:30,
from
/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/include/cmath:45,
from
../../../.././libstdc++-v3/src/c++17/floating_from_chars.cc:34:
../../../.././libstdc++-v3/src/c++17/floating_from_chars.cc:322:22:
error: ‘__builtin_isinf_sign’ is not a member of ‘std’; did you mean
‘__builtin_isinf_sign’?
322 | if (std::isinf(tmpval)) // overflow
| ^~~~~
<built-in>: note: ‘__builtin_isinf_sign’ declared here
make[6]: *** [Makefile:572: floating_from_chars.lo] Error 1
make[6]: Leaving directory
'/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/src/c++17'
make[5]: *** [Makefile:732: all-recursive] Error 1
make[5]: Leaving directory
'/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3/src'
make[4]: *** [Makefile:564: all-recursive] Error 1
make[4]: Leaving directory
'/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3'
make[3]: *** [Makefile:489: all] Error 2
make[3]: Leaving directory
'/home/anadon/Documents/code/gcc/x86_64-pc-linux-gnu/libstdc++-v3'
make[2]: *** [Makefile:19986: all-stage1-target-libstdc++-v3] Error 2
make[2]: Leaving directory '/home/anadon/Documents/code/gcc'
make[1]: *** [Makefile:28047: stage1-bubble] Error 2
make[1]: Leaving directory '/home/anadon/Documents/code/gcc'
make: *** [Makefile:1007: all] Error 2
```
On Tue, Jul 28, 2020 at 7:28 PM Josh Marshall
<joshua.r.marshall.1991@gmail.com> wrote:
>
> Hello all,
>
> I'm looking to make my first contribution to this project since I need
> constexpr vector for a project. I'll be finishing the legal forms and
> reading through contributor guides this evening. Is there any
> particular advice for this project to keep in mind?
More information about the Libstdc++
mailing list