[PATCH] libstdcxx: Update ctype_base.h from NetBSD upstream

Jonathan Wakely jwakely@redhat.com
Thu Jan 16 17:47:00 GMT 2020


On 14/01/20 08:56 -0800, Jason Thorpe wrote:
>
>
>> On Jan 14, 2020, at 8:49 AM, Kamil Rytarowski <n54@gmx.com> wrote:
>>
>> On 10.01.2020 17:11, Jonathan Wakely wrote:
>>> On 07/01/20 12:44 -0800, Jason Thorpe wrote:
>>>>
>>>>> On Jan 7, 2020, at 7:43 AM, Jonathan Wakely <jwakely@redhat.com> wrote:
>>>>>
>>>>> For Jason and Krister's benefit, that last comment was referring to
>>>>> an earlier suggestion to not try to support old NetBSD releases, see
>>>>> https://gcc.gnu.org/ml/libstdc++/2020-01/msg00026.html
>>>>>
>>>>>> I think we need the netbsd target maintainers (CC'd) to decide whether
>>>>>> GCC should still support older releases or drop that support for GCC
>>>>>> 10. Usually I'd say we need a period of deprecation, but if GCC
>>>>>> doesn't currently build on NetBSD then maybe that's unnecessary.
>>>>
>>>> The affected NetBSD versions are NetBSD 6 and earlier, which are EOL
>>>> from the NetBSD perspective, so I think this is OK.
>>>
>>> So is this patch OK then?
>>>
>>
>> Looks good to me.
>
>Now that we have Kamil's confirmation that it's working for him, it also gets a thumbs-up from me.
>
>Thanks!

Thanks to everyone for their feedback. I've pushed the patch to GCC
master now (I think it's reasonable to consider "doesn't build on
NetBSD anymore" as a regression and so fixable at this point in GCC's
development).

Please let me know of any problems you find with the changes.




More information about the Libstdc++ mailing list