[PATCH] Rename condition_variable_any::wait_on_* methods

Thomas Rodgers trodgers@redhat.com
Wed Jan 8 03:11:00 GMT 2020


Tested x86_64-pc-linux-gnu, committed to trunk.

Jonathan Wakely writes:

> On 10/12/19 22:38 -0800, Thomas Rodgers wrote:
>>User-agent: mu4e 1.3.4; emacs 26.2
>>	* include/std/condition_variable
>>	(condition_variable_any::wait_on(_Lock&, stop_token, _Predicate): Rename
>>	to match current draft standard.
>>	(condition_variable_any::wait_on_until(_Lock&, stop_token,
>>	const chrono::time_point<>&, _Predicate): Likewise.
>>	(condition_variable_any::wait_on_for(_Lock&, stop_token,
>>	const chrono::duration<>&, _Predicate(: Likewise.
>
> The closing paren here is an opening one. OK for trunk with that
> fixed.
>
> Optional tweaks ...
>
> Since the names wait_on, wait_on_until and wait_on_for are
> unambiguous, you could just list them without parameters i.e.
>
> 	* include/std/condition_variable (condition_variable_any::wait_on)
>        (condition_variable_any::wait_on_until)
>        (condition_variable_any::wait_on_for): Rename to match current
>        draft standard.
>
>>	* testsuite/30_threads/condition_variable_any/stop_token/wait_on.cc (main):
>
> We don't generally both to say which functions were modified in tests,
> so the (main) isn't needed here, but is harmless.
>
>>	Adjust tests to account for renamed methods.



More information about the Libstdc++ mailing list