[PATCH] Fix libstdc++ testsuite to handle VxWorks gthreads implementation

Jonathan Wakely jwakely@redhat.com
Mon Aug 24 15:09:39 GMT 2020


On 21/08/20 09:37 -0300, Alexandre Oliva wrote:
>On Dec 20, 2019, Jonathan Wakely <jwakely at redhat dot com> wrote:
>
>> On 10/12/19 15:58 +0100, Corentin Gay wrote:
>>> This patch was tested on x86_64-linux and is part of our nightly testing
>>> on all platforms, including VxWorks.
>
>> Was it tested on AIX?
>
>> I think dg-require-gthreads will prevent the tests running for the
>> single-threaded multilib on AIX, so it will work OK. But there's a
>> chance it will need fixing. Let's wait and see (I'm currently unable
>> to build GCC on AIX).
>
>Sorry it took us so long to get back on this.  I've just refreshed the
>patch at <https://gcc.gnu.org/legacy-ml/gcc-patches/2019-12/msg00690.html>:
>
>- resolving some trivial conflicts within 30_threads/shared_mutex,
>
>- updating some renamed test file names within 30_threads/this_thread, and
>
>- dropping the obviated change to 30_threads/this_thread/yield.cc
>
>and gave it a spin on gcc111 in the cfarm.
>
>There weren't any changes to the libstdc++ results, according to
>test_summary, not even in the unsupported (or any other) test counts.
>
>> OK for trunk, thanks.
>
>Given the approval and the lack of significant changes, I'll put this in
>unless there are objections in the next 48 hours.  Thanks for the review!


Thanks. There's a new FAIL due to a bad merge.

That test needs to be restricted to C++11 and C++14, which I did
recently on master. However, since the default became -std=gnu++17
that means it stopped running on master. Since your patch it runs
again, but now fails.

This fixes it to use an explicit -std=gnu++11 and not run for C++17.

Pushed to master.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.txt
Type: text/x-patch
Size: 987 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/libstdc++/attachments/20200824/0e6d91f0/attachment.bin>


More information about the Libstdc++ mailing list