Hashtable comment cleanups & renamings

François Dumont frs.dumont@gmail.com
Fri May 17 16:19:00 GMT 2019


Hi

     I got tired of '__n' being used in _Hashtable for many different 
purposes: node, bucket, bucket count, bucket hint. It makes the code 
difficult to read. This code makes sure that __n is a node except is 
some very limited use cases where the method name is clear enough to 
tell what __n means.

     So I'd like to commit this patch which only change that and some 
comments before moving forward to more serious stuff. The only code 
change is a use of auto return type on _M_allocate_node.

     My main concern is the ChangeLog entry. Is the following entry ok ?

     Rename variables and cleanup comments.
     * include/bits/hashtable_policy.h
     * include/bits/hashtable.h

     Tested under Linux x86_64 (even if it can't be otherwise)

François

-------------- next part --------------
A non-text attachment was scrubbed...
Name: hashtable_renames.patch
Type: text/x-patch
Size: 38046 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20190517/8479d4c2/attachment.bin>


More information about the Libstdc++ mailing list