Fix make check-debug RUNTESFLAGS=prettyprinters.exp
Jonathan Wakely
jwakely@redhat.com
Sat May 4 13:14:00 GMT 2019
On 04/05/19 09:31 +0200, François Dumont wrote:
>Hi
>
>Â Â Â This patch allows to run pretty printer tests in _GLIBCXX_DEBUG
>mode. If accepted we could even integrate the pretty printers tests
>within the check-debug target like it is done for the check target.
>
>
>Â Â Â * python/libstdcxx/v6/printers.py (add_one_template_type_printer):
>Â Â Â Add type printer for container types in std::__debug namespace.
>Â Â Â * testsuite/lib/gdb-test.exp (whatis-regexp-test): New.
>Â Â Â (gdb-tests): Use distinct parameters for the type of test and use of
>Â Â Â regex.
>Â Â Â (gdb-test): Check for regex test even if 'whatis' test.
>Â Â Â * testsuite/libstdc++-prettyprinters/80276.cc: Adapt for _GLIBCXX_DEBUG
>Â Â Â mode.
>Â Â Â * testsuite/libstdc++-prettyprinters/cxx11.cc: Likewise.
>Â Â Â * testsuite/libstdc++-prettyprinters/cxx17.cc: Likewise.
>Â Â Â * testsuite/libstdc++-prettyprinters/libfundts.cc: Likewise.
>Â Â Â * testsuite/libstdc++-prettyprinters/simple.cc: Likewise.
>Â Â Â * testsuite/libstdc++-prettyprinters/simple11.cc: Likewise.
>Â Â Â * testsuite/libstdc++-prettyprinters/whatis.cc: Likewise.
>Â Â Â * testsuite/libstdc++-prettyprinters/whatis2.cc: Likewise.
Looks good, I'm glad the actual printers.py file isn't made more
complicated to support this.
>Â Â Â Tested under Linux x86_64 normal and debug modes.
>
>Â Â Â I only have 1 failure left in both normal and debug modes:
>
>got: type = std::unique_ptr<std::vector<std::unique_ptr<std::list<std::__cxx11::basic_string<char,
>std::char_traits<char>, std::allocator<char> >>[]>>[99]>
>FAIL: libstdc++-prettyprinters/80276.cc whatis p4
>
>Â Â Â But I think it is because of the usage of the C++11 abi std::string.
That's https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83906
>Ok to commit ?
OK for trunk, thanks.
More information about the Libstdc++
mailing list