[PATCH] Fix ODR violations in code using <ext/atomicity.h>
Jonathan Wakely
jwakely@redhat.com
Fri Jul 5 18:44:00 GMT 2019
On 05/07/19 20:23 +0200, Daniel Krügler wrote:
>Am Fr., 5. Juli 2019 um 18:13 Uhr schrieb Jonathan Wakely <jwakely@redhat.com>:
>>
>[..]
>> I decided against the simplification in the second patch, and
>> committed the attached one which is closer to the first patch I sent
>> (preserving the __atomic_add and __exchange_and_add functions even
>> when they just call the built-ins).
>>
>> Tested x86_64-linux, powerpc64-linux, powerpc-aix. Committed to trunk.
>
>Unrelated to the actual patch, I noticed some explicit "throw()" forms
>used as exception specifications - shouldn't these be replaced by
>either explicit "noexcept" or at least by a library macro that expands
>to one or the other?
Yes, they should be _GLIBCXX_NOTHROW.
>(I'm sorry, if such unrelated questions are
>considered as inappropriate for this list).
Entirely appropriate, thanks!
More information about the Libstdc++
mailing list