[PATCH, testsuite] Skip new charset tests on Darwin8-10.

Jonathan Wakely jwakely@redhat.com
Mon Jan 14 11:27:00 GMT 2019


On 12/01/19 16:46 +0000, Iain Sandoe wrote:
>Hi,
>
>These earlier Darwin versions have “FP_≈” inside a comment in architecture/{ppc,i386}/math.h, which is included by math.h which causes the tests to fail.
>
>The intent of the tests (i.e. to ensure that the library itself does not emit non-ascii) is covered by other platforms, including later Darwin editions.  AFAICT, this issue was fixed from Darwin11 onwards (although I have not tested every edition / looked for other possible non-ascii cases, in other headers).
>
>Since there’s no expectation that the headers would ever be updated, and it doesn’t seem worth applying fixincludes for this, let’s skip the tests on versions with the issue.
>
>Tested on powerpc-darwin9, x86_64-darwin10 and x86_64-darwin18.
>
>OK for trunk?

OK, thanks.



More information about the Libstdc++ mailing list