[PATCH] Pretty printer test fixes and improvements

[Jonathan Wakely]

On 09/01/19 10:14 +0000, Jonathan Wakely wrote:
>On 09/01/19 11:09 +0100, Christophe Lyon wrote:
>>On Wed, 9 Jan 2019 at 00:16, Jonathan Wakely <jwakely@redhat.com> wrote:
>>>
>>>Test that StdUniquePtrPrinter correctly prints std::unique_ptr objects
>>>using the old layout, prior to the PR libstdc++/77990 changes.
>>>
>>>The printer test for a valueless std::variant started to fail because
>>>the PR libstdc++/87431 fix meant it no longer became valueless. Change
>>>the test to use a type that is not trivially copyable, so that the
>>>exception causes it to become valueless.
>>>
>>>        * testsuite/libstdc++-prettyprinters/compat.cc: Test printer support
>>>        for old std::unique_ptr layout.
>>>        * testsuite/libstdc++-prettyprinters/cxx17.cc: Fix std::variant test
>>>        to become valueless. Add filesystem::path tests.
>>>
>>>Tested x86_64-linux, committed to trunk.
>>>
>>
>>Hi Jonathan,
>>
>>After this patch, I've noticed a new failure on aarch64:
>>FAIL: libstdc++-prettyprinters/cxx17.cc print p2
>>
>>The log contains:
>>PASS: libstdc++-prettyprinters/cxx17.cc print p1
>>$27 = filesystem::path "/dir/." = {[root-directory] = "/", [1] =
>>"dir", [2] = "."}
>>got: $27 = filesystem::path "/dir/." = {[root-directory] = "/", [1] =
>>"dir", [2] = "."}
>>FAIL: libstdc++-prettyprinters/cxx17.cc print p2
>
>Hmm, that's the expected output. I wonder why it fails.

Oh, it's not the expected output at all. I'm being dumb.

I am seeing that failure too, but didn't notice it along with all the
existing ones caused by PR 88170 (which was also the problem with the
std::variant failure fixed in r267743).

The attached patch fixes it, committed to trunk.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.txt
Type: text/x-patch
Size: 1848 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20190109/9e25d5bc/attachment.bin>