[PATCH] Make std::list::iterator == and != global inline friend
Jonathan Wakely
jwakely@redhat.com
Tue Oct 9 11:31:00 GMT 2018
On 09/10/18 07:25 +0200, François Dumont wrote:
>As we talked one day I would like to make all iterator operators
>global for consistency. So here is the patch to do so for std::list
>iterators.
By "global" you mean "non-member", right?
>
>Thanks to this change the operators ==(iterator, const_iterator) and
>!= are not necessary anymore, one less ==|!= operator candidate.
>
>Â Â Â * include/bits/stl_list.h
>Â Â Â (_List_operator<>::operator==): Make global inline friend.
I find this description a bit confusing. Please use "Replace member
function with inline friend" instead.
>Â Â Â (_List_operator<>::operator!=): Likewise.
>Â Â Â (_List_const_operator<>::operator==): Likewise.
>Â Â Â (_List_const_operator<>::operator!=): Likewise.
>Â Â Â (operator==(const _List_iterator<>&, const _List_const_iterator<>&)):
>Â Â Â Remove.
>Â Â Â (operator!=(const _List_iterator<>&, const _List_const_iterator<>&)):
>Â Â Â Remove.
>
>Tested under Linux x86_64.
>
>Ok to commit ?
OK with the revised changelog text, thanks.
More information about the Libstdc++
mailing list