Fix pretty printers in _GLIBCXX_DEBUG mode

[François Dumont]

On 09/28/2018 02:01 PM, Jonathan Wakely wrote:
> On 25/09/18 22:11 +0200, François Dumont wrote:
>>
>> I guess it must have something to do with the [] but as I escaped 
>> both I don't understand what's wrong.
>
> You might need to escape them twice, or more ... so that TCL doesn't
> try to handle them as special characters, and then the regex engine
> doesn't treat them as special characters either.
>
>
Ok, with some additionals escape characters it now succeeds. So now the 
question is: ok to commit ?

It makes the tests a little bit more complicated so I would understand 
that you reject it. At the same time I regularly see those tests 
reported as in failure so I guess we want them to succeed and it is the 
only way I found to fix them. Another option would be to try to hide 
'__debug::' from a whatis call but I don't want to hide it from our 
users just to make our tests pass.

 Â Â Â  * python/libstdcxx/v6/printers.py (add_one_template_type_printer):
 Â Â Â  Add type printer for container types in std::__debug namespace.
 Â Â Â  * testsuite/lib/gdb-test.exp (whatis-regexp-test): New.
 Â Â Â  (gdb-tests): Use distinct parameters for the type of test and use 
regex.
 Â Â Â  (gdb-test): Check for regex test even if 'whatis' test.
 Â Â Â  * testsuite/libstdc++-prettyprinters/80276.cc: Adapt for _GLIBCXX_DEBUG
 Â Â Â  mode.
 Â Â Â  * testsuite/libstdc++-prettyprinters/cxx11.cc: Likewise.
 Â Â Â  * testsuite/libstdc++-prettyprinters/cxx17.cc: Likewise.
 Â Â Â  * testsuite/libstdc++-prettyprinters/libfundts.cc: Likewise.
 Â Â Â  * testsuite/libstdc++-prettyprinters/simple11.cc: Likewise.
 Â Â Â  * testsuite/libstdc++-prettyprinters/whatis.cc: Likewise.
 Â Â Â  * testsuite/libstdc++-prettyprinters/whatis2.cc: Likewise.

Tested under Linux x86_64 debug and normal modes.

François

-------------- next part --------------
A non-text attachment was scrubbed...
Name: debug_printers.patch
Type: text/x-patch
Size: 20942 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20181001/e38a6e30/attachment.bin>