[PATCH] Add baseline symbols for riscv64-linux-gnu
Jonathan Wakely
jwakely@redhat.com
Tue Jul 17 00:02:00 GMT 2018
On 16/07/18 16:37 -0700, Jim Wilson wrote:
>On Mon, Jul 16, 2018 at 3:24 AM, Andreas Schwab <schwab@suse.de> wrote:
>> * config/abi/post/riscv64-linux-gnu/baseline_symbols.txt: New file.
>>
>
>I'm not familiar with the details of these baseline symbol files.
>
>When I try running "make new-abi-baseline" on my Fedora riscv64-linux
>system using top of tree, I get 35 extra lines in the
>baseline_symbols.txt.new file. It looks like 33 of them are because I
>have
>OBJECT:0:GLIBCXX_3.4.26
>and yours only goes up to 3.4.25. The other two are TLS entries.
>> TLS:8:_ZSt11__once_call@@GLIBCXX_3.4.11
>> TLS:8:_ZSt15__once_callable@@GLIBCXX_3.4.11
>Not sure why there are no TLS entries in your file, and two in mine.
I don't know about RISC-V but for other GNU/Linux targets those
symbols are not always present, so should not be listed in the
baseline (otherwise when they're absent you get errors about missing
symbols).
>The testsuite does pass with a message about 33 added symbols and 2
>undesignated symbols which are the TLS symbols.
The added symbols all have the new GLIBCXX_3.4.26 symbol version, so
are allowed as additions on top of the GLIBCXX_3.4.25 baseline defined
by the baseline_symbols.txt file.
The 3.4.26 version is still "open" and having new symbols added to it,
so it makes sense for the baseline to only go up to 3.4.25 for now.
More information about the Libstdc++
mailing list