Make safe_iterator inline friends

[François Dumont]

Thanks for all those explanations. It helped me to find the solution.

So here is the final patch with all operators inline friends.

Tested under Linux x86_64.

 Â Â Â  * include/debug/safe_iterator.h
 Â Â Â  (_Safe_iterator<_It, _Seq, std::random_access_iterator_tag>::_Self):
 Â Â Â  New.
 Â Â Â  (_Safe_iterator<_It, _Seq, std::random_access_iterator_tag>
 Â Â Â  ::_OtherSelf): New.
 Â Â Â  (_GLIBCXX_DEBUG_VERIFY_OPERANDS, _GLIBCXX_DEBUG_VERIFY_CMP_OPERANDS)
 Â Â Â  (_GLIBCXX_DEBUG_VERIFY_ORDER_OPERANDS)
 Â Â Â  (_GLIBCXX_DEBUG_VERIFY_DIST_OPERANDS): Define macros.
 Â Â Â  (_Safe_iterator<_It, _Seq, std::random_access_iterator_tag>
 Â Â Â  ::operator+(difference_type)): Use latters, inline as friend.
 Â Â Â  (_Safe_iterator<_It, _Seq, std::random_access_iterator_tag>
 Â Â Â  ::operator-(difference_type)): Likewise.
 Â Â Â  (operator==(const _Safe_iterator<>&, const _Safe_iterator<>&)):
 Â Â Â  Likewise.
 Â Â Â  (operator!=(const _Safe_iterator<>&, const _Safe_iterator<>&)):
 Â Â Â  Likewise.
 Â Â Â  (operator<(const _Safe_iterator<>&, const _Safe_iterator<>&)): 
Likewise.
 Â Â Â  (operator<=(const _Safe_iterator<>&, const _Safe_iterator<>&)):
 Â Â Â  Likewise.
 Â Â Â  (operator>(const _Safe_iterator<>&, const _Safe_iterator<>&)): 
Likewise.
 Â Â Â  (operator>=(const _Safe_iterator<>&, const _Safe_iterator<>&)):
 Â Â Â  Likewise.
 Â Â Â  (operator-(const _Safe_iterator<>&, const _Safe_iterator<>&)): 
Likewise.
 Â Â Â  (operator+(difference_type, const _Safe_iterator<>&)): Likewise.
 Â Â Â  (operator-(const _Safe_iterator<>&, difference_type)): Likewise.
 Â Â Â  * include/debug/safe_iterator.tcc
 Â Â Â  (_Safe_iterator<>::_M_can_advance(difference_type)): Take parameter by
 Â Â Â  copy.
 Â Â Â  * include/debug/safe_local_iterator.h
 Â Â Â  (_Safe_local_iterator<_It, _Seq>::_Self): New.
 Â Â Â  (_Safe_local_iterator<_It, _Seq>::_OtherSelf): New.
 Â Â Â  (_GLIBCXX_DEBUG_VERIFY_OPERANDS): Define macro.
 Â Â Â  (operator==(const _Safe_local_iterator<>&,
 Â Â Â  const _Safe_local_iterator<>&)): Use latter, inline as friend.
 Â Â Â  (operator!=(const _Safe_local_iterator<>&,
 Â Â Â  const _Safe_local_iterator<>&)): Likewise.
 Â Â Â  * testsuite/util/testsuite_containers.h
 Â Â Â  (struct forward_members_unordered<_Tp, bool>): Remove 2nd template
 Â Â Â  parameter.
(forward_members_unordered<>::forward_members_unordered(value_type&)):
 Â Â Â  Add using namespace std::rel_ops.
 Â Â Â  Add iterator_concept_checks on local_iterator and const_local_iterator.
 Â Â Â  Add asserts on comparison between const_local_iterator and
 Â Â Â  local_iterator.
 Â Â Â  (struct forward_members_unordered<_Tp, false>): Remove partial
 Â Â Â  specialization.
 Â Â Â  * testsuite/23_containers/forward_list/types/1.cc: New.
 Â Â Â  * testsuite/23_containers/list/types/1.cc: New.

Ok to commit ?

François
-------------- next part --------------
A non-text attachment was scrubbed...
Name: safe_iterator_operators.patch
Type: text/x-patch
Size: 33702 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/libstdc++/attachments/20180830/19132b38/attachment.bin>