[PATCH] streambuf_iterator: avoid debug-dependent behaviour

Jonathan Wakely jwakely@redhat.com
Fri Sep 1 09:10:00 GMT 2017


On 24/08/17 12:57 +0300, Petr Ovtchenkov wrote:
>Explicit do sgetc from associated streambuf. Avoid debug-dependent
>sgetc (within _M_at_eof()):
>
>       __glibcxx_requires_cond(!_M_at_eof(),
>                               _M_message(__gnu_debug::__msg_inc_istreambuf)
>                               ._M_iterator(*this));
>
>Increment operators not require not-eof precoditions.
>
>Don't unlink associated streambuf if eof detected (in _M_get).
>
>Clean logic in postfix increment operator.

I find it very hard to understand the reasons for this patch. What
you've written above is too terse for me.

Are you fixing a bug? If so, do you have a testcase that demonstrates
the problem, and is fixed by these changes?

Is this just refactoring, without changing behaviour?

Finally, and very importantly, do you have a copyright assignment for
changes to GCC? See https://gcc.gnu.org/contribute.html#legal




More information about the Libstdc++ mailing list